Page MenuHomeVyOS Platform
Create Task
Maniphest T2372

VLAN: error on commit if main interface is disabled
Closed, ResolvedPublicBUG
Actions

Description

Create VLAN interfaces

set interfaces ethernet eth1 vif 5 address '192.0.2.1/28'
set interfaces ethernet eth1 vif 5 address '2001:db8:0:::ffff/64'
set interfaces ethernet eth1 vif 10 address '192.0.2.17/28'
set interfaces ethernet eth1 vif 10 address '2001:db8:1:ffff/64'
commit

Disable pyhsical interface

set interfaces ethernet eth1 disable
commit
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/interfaces-ethernet.py", line 437, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/interfaces-ethernet.py", line 428, in apply
    apply_vlan_config(vlan, vif)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig_vlan.py", line 77, in apply_vlan_config
    vlan.set_admin_state('up')
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/interface.py", line 557, in set_admin_state
    return self.set_interface('admin_state', state)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/control.py", line 154, in set_interface
    return self._set_command(self.config, name, value)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/control.py", line 82, in _set_command
    return self._command_set[name].get('format', lambda _: _)(self._cmd(cmd))
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/control.py", line 48, in _cmd
    return cmd(command, self.debug)
  File "/usr/lib/python3/dist-packages/vyos/util.py", line 139, in cmd
    raise OSError(code, feedback)
FileNotFoundError: [Errno 2] failed to run command: ip link set dev eth0.5 up
returned:
exit code: 2

Details

Version
1.3-rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

c-po created this task.Apr 23 2020, 5:05 PM
pasik subscribed.Apr 24 2020, 6:06 AM
Restricted Repository Identity mentioned this in rVYOSONEX932657a64a7f: Merge pull request #383 from thomas-mangin/T2372.May 2 2020, 12:12 PM
Restricted Repository Identity mentioned this in rVYOSONEXb47e7ebab5b9: Merge pull request #387 from thomas-mangin/T2372.May 2 2020, 4:09 PM
jjakob assigned this task to thomas-mangin.May 5 2020, 8:27 AM
jjakob added subscribers: thomas-mangin, jjakob.

@thomas-mangin there was a bug in PR #383 that prevented bond interfaces from coming up - it thought the members had addresses assigned, but they didn't. Something in my PR#384 fixed it - I'm not exactly sure what - probably assigning the intf['intf'] in get_intf_from_dict or fixing the _basename function. There is still a bug with IPv6 link-locals that worked fine before - I'll see if it's easy to track down, if not I'll open a new task for it.

jjakob added a comment.May 5 2020, 9:10 AM

Why do we need to remove all addresses from the interface when it is disabled? That causes a commit error on dhcp:

vyos@vyos# set service dhcp-server disable 
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# delet service dhcp-server disable 
[edit]
vyos@vyos# commit
[ service dhcp-server ]
DHCP server configuration error!
None of configured DHCP subnets does not have appropriate
primary IP address on any broadcast interface.

[[service dhcp-server]] failed
Commit failed
[edit]

Also the running service logs errors, but dhcpd seems to handle them gracefully and doesn't die:
vyos dhcpd[7765]: receive_packet failed on bond0: Network is down

If you agree, I'll change it back to the way it was when disable just sets the interface admin down.

jjakob mentioned this in T2427: Interface addressing broken since fix for T2372 was merged.May 5 2020, 1:25 PM
thomas-mangin added a comment.May 8 2020, 9:43 AM

Why do we need to remove all addresses from the interface when it is disabled?

It was a misunderstanding on my side of what disable should do.

jjakob added a comment.May 9 2020, 9:04 AM

Since the issue is resolved can this be closed?

thomas-mangin closed this task as Resolved.May 10 2020, 9:26 AM
c-po mentioned this in rVYOSONEXe62218c87a99: configdict: T2372: interfaces must reuse interface_default_data.May 19 2020, 7:31 PM
c-po mentioned this in rVYOSONEX3e76f032c22f: configdict: T2372: use list over string.
c-po mentioned this in rVYOSONEX77eaf77f4fde: configdict: T2372: add new interface_default_data dict.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:21 PM
c-po mentioned this in rVYOSONEX3508feea888b: configdict: T2372: use config.exists() when probing for interface removal.Oct 1 2020, 5:44 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:36 AM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:02 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.