Page MenuHomeVyOS Platform
Create Task
Maniphest T2362

IPv6 link-local addresses missing due to EUI64 address code, causing router-advert not to work
Closed, ResolvedPublic
Actions

Description

There is a bug in current code: if 'ipv6 address eui64' is unset (default), the default kernel-assigned link-local 'fe80::.../64' address is deleted from the interface. This breaks IPv6 router-advert and other IPv6 things.

To correctly handle this case, break apart set_ipv6_eui64_address into add_ and del_ functions that simply add/delete the given prefix+eui64, then add a default 'fe80::/64' eui64 address in all interface scripts.

To complement this change, add the ability to delete the default link-local address via 'ipv6 address no-default-link-local' or similar, and expand the eui64 code to support more than 1 prefix.

Interfaces that are part of bridges should not have any addresses, link-local or otherwise, so add code to detect this and not add the default link-local prefix in that case. Later, a validation can be added that raises a ConfigError if an interface has an address assigned while being added to a bridge.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

jjakob renamed this task from Separate IPv6 link-local addresses from EUI64 prefixes, allow setting multiple link-local or EUI64 addresses to Separate IPv6 link-local addresses from EUI64 prefixes, allow setting multiple EUI64 addresses.Apr 21 2020, 7:07 PM
jjakob changed the task status from Open to In progress.
jjakob triaged this task as High priority.
jjakob created this task.
jjakob created this object in space S1 VyOS Public.
jjakob added subtasks: T2345: IPv6 router-advert not working, T2348: On IPv6 address distribution and DHCPv6 bugs.
jjakob added a comment.EditedApr 21 2020, 8:51 PM

https://github.com/vyos/vyos-1x/pull/371

jjakob moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.Apr 21 2020, 9:18 PM
jjakob added a comment.Apr 21 2020, 9:50 PM

The above PR is tested to fix this issue and T2345.

Todo:

  • set sysctl addr_gen_mode=1 to tell the kernel to not generate a link-local, otherwise the intf's MAC changes after a member is added so we can't delete the kernel's link-local any more
  • remove link-locals from bridge slaves
jjakob renamed this task from Separate IPv6 link-local addresses from EUI64 prefixes, allow setting multiple EUI64 addresses to IPv6 link-local addresses missing due to EUI64 address code, causing router-advert not to work.Apr 21 2020, 11:05 PM
jack9603301 added a subscriber: jack9603301.Apr 22 2020, 2:16 AM
jack9603301 changed the status of subtask T2348: On IPv6 address distribution and DHCPv6 bugs from Open to In progress.Apr 22 2020, 4:06 AM
pasik added a subscriber: pasik.Apr 22 2020, 11:02 AM
jjakob mentioned this in T2367: Flush addresses from bridge members.Apr 22 2020, 7:06 PM
jjakob closed this task as Resolved.Apr 23 2020, 8:10 PM
jjakob moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
jjakob closed subtask T2345: IPv6 router-advert not working as Resolved.
jjakob mentioned this in T2345: IPv6 router-advert not working.
jjakob changed the status of subtask T2348: On IPv6 address distribution and DHCPv6 bugs from In progress to Needs testing.Apr 23 2020, 8:14 PM
jjakob mentioned this in T2348: On IPv6 address distribution and DHCPv6 bugs.
jack9603301 closed subtask T2348: On IPv6 address distribution and DHCPv6 bugs as Resolved.Apr 24 2020, 11:59 AM
Unknown Object (User) mentioned this in T3393: IPoE does not assign IPv6 PD or WAN address.Mar 8 2021, 7:08 PM
bbabich added a subscriber: bbabich.Aug 4 2021, 4:00 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:39 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:02 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.