https://github.com/vyos/vyos-1x/pull/361

Works for me

This code doesnt break if ipv6 is disabled by system wide:

openvpn['protocol_real'] = openvpn['protocol'][:3]
if not is_ipv4(openvpn['local_host']) and not detect_if_systemipv6_is_disabled():
   openvpn['protocol_real'] += "6"

if openvpn['protocol'] == 'tcp-active':
   openvpn['protocol_real'] += '-client'
elif openvpn['protocol'] == 'tcp-passive':
   openvpn['protocol_real'] = '-server'

Looks good. Is detect_if_systemipv6_is_disabled() already a
system function? If so, It can be incorporated (by you if you wish, or by
me). The last line is missing += by the way.

Apr 23, 2020 2:10:08 AM elbandi (Elbandi) <[email protected]>:

elbandi added a comment.

my code is:

openvpn['protocol_real'] = openvpn['protocol'][:3]
if not is_ipv4(openvpn['local_host']) and not

detect_if_systemipv6_is_disabled():

openvpn['protocol_real'] += "6"

if openvpn['protocol'] == 'tcp-active':
openvpn['protocol_real'] += '-client'
elif openvpn['protocol'] == 'tcp-passive':
openvpn['protocol_real'] = '-server'

TASK DETAIL
https://phabricator.vyos.net/T2339

EMAIL PREFERENCES
https://phabricator.vyos.net/settings/panel/emailpreferences/

To: jjakob, elbandi
Cc: elbandi, pasik, Active contributors, Maintainers, c-po, teadur,

jack9603301, hard, pa4ka, jestabro, Alfa80, dongjunbo, hexes

Disabling IPv6 on the system is something not mainlined in VyOS - there are open PRs on GitHub which needs to be approved by @dmbaturin. As Disabling IPv6 would also require the CLI to disable all IPv6 inputs dynamically which is something not possible at the moment.

@jjakob detect_if_systemipv6_is_disabled just an idea, but looking to interfaces-openvpn.py, it's easy:

is_ipv6_disabled = conf.exists('system ipv6 disable')

before conf.set_level in get_config. so:

if not is_ipv4(openvpn['local_host']) and not is_ipv6_disabled:

@c-po systemwide ipv6 disable is working good in 1.3-20200324. i would be sad if it was removed :(

Hi,

This bug exists for remote-host as well.

In T2339#65130, @danielpo wrote:

Hi,

This bug exists for remote-host as well.

remote-host fix attempt:
https://github.com/vyos/vyos-1x/pull/443 (T2550#66134)

Indeed, I didn't test client mode with the IPv6 patch, I assumed openvpn would use 'proto' for the listening socket only and not for the client socket (since it could detect which family the remote-host address is, it could select the correct socket, but it honors the 'proto' in the config) so my assumption was wrong. I appreciate the help.