Maniphest T2230

Split out inlined Jina2 template to data/templates folder
Closed, ResolvedPublicFEATURE REQUEST
Actions

Assigned To

Authored By

	c-po
	Apr 5 2020, 2:32 PM

Tags

Referenced Files

None

Subscribers

Description

Back in the days when only small parts have been migrated to JInja2 the templates have been placed inside the Python file which did the configuration.

As more and more parts are getting migrated it has been found out that this sometimes super clutters the entire Python script.

Bad examples:

Wireless Interfaces (WIFI)
DHCP
Wireless Modem (multiple templates)

Thus all templates should be removed from the Python file and placed into the dedicates template folder to unclutter the Python configuration logic.

Details

Version: -
Is it a breaking change?: Perfectly compatible
Issue type: Internal change (not visible to end users)

Related Objects

Mentioned In: rVYOSONEX51bdfc7e04b9: dhcp-server: T2230: add subnet description into rendered config
rVYOSONEX2974628487ab: dhcp-server: T2230: add subnet description into rendered config
rVYOSONEXa0202eaf489c: igmp: T2230: fix Jinja2 and FRR indention
rVYOSONEX424c08b6a871: https: T2230: only support TLS1.2 and TLS1.3
rVYOSONEX7546e249708d: https: T2230: only support TLS1.2 and TLS1.3
rVYOSONEX90b9eeacfb62: Merge pull request #997 from c-po/nginx-tls-12-13
rVYOSONEX6c286fab17e8: lldp: T2230: verify file exists before unlinking it
rVYOSONEXca202f30fc5f: lldp: T2230: verify file exists before unlinking it
rVYOSONEX6a957e7955b6: ssh: T2230: remove duplicated HostKey line
rVYOSONEX152a147c3a34: ntp: T2230: fix wrong import after template migration
rVYOSONEX8978c7eaf4b1: Merge pull request #332 from thomas-mangin/T2230
T2265: DHCP to be an attribute of the class instead of a inheritance
rVYOSONEX1730afc6ebb5: ipsec: T2230: bugfix code cleanup
rVYOSONEX10c06217a53b: ipsec: T2230: bugfix rewriting Jinja2 code
rVYOSONEXdbc174dd2b85: ipsec: T2230: move inlined templates to dedicated files
rVYOSONEX6b4aed73cbb1: salt-minion: T2230: move inlined templates to dedicated files
rVYOSONEX118681664310: pim: T2230: move inlined templates to dedicated files
rVYOSONEXda6883549b7e: mpls: T2230: move inlined templates to dedicated files
rVYOSONEXefe8eaa626a6: igmp: T2230: move inlined templates to dedicated files
rVYOSONEX839189228915: ipoe-server: T2230: move inlined templates to dedicated files
rVYOSONEXebb54c107e30: pppoe-server: T2230: move inlined templates to dedicated files
rVYOSONEX59cf7f59ac69: pptp: T2230: move inlined templates to dedicated files
rVYOSONEX3ea3c8ed6bd4: router-advert: T2230: move inlined templates to dedicated files
rVYOSONEX5a04f7d6a9c4: wifi-regdom: T2230: move inlined templates to dedicated files
rVYOSONEX5171e61d9b30: system-login: T2230: move inlined templates to dedicated files
rVYOSONEX6563f29bedb6: vrrp: T2230: convert template from dos to unix line endings
rVYOSONEX1556b15e9644: https: T2230: convert template from dos to unix line endings
rVYOSONEXbc848a8e62c3: mdns-repeater: T2230: convert template from dos to unix line endings
rVYOSONEX542cdf7b5e16: vrf: T2230: move inlined templates to dedicated files
rVYOSONEX166b86163824: bfd: T2230: move inlined templates to dedicated files
rVYOSONEX481bd0bfa9f3: tftp-server: T2230: move inlined templates to dedicated files
rVYOSONEX578cb6efbc08: mdns-repeater: T2230: move inlined templates to dedicated files
rVYOSONEX272a738aa560: https: T2230: move inlined templates to dedicated files
rVYOSONEXf69924cf4dae: igmp-proxy: T2230: move inlined templates to dedicated files
rVYOSONEXc3770f57a322: dynamic-dns: T2230: move inlined templates to dedicated files
rVYOSONEX108979391c58: syslog: T2230: move inlined templates to dedicated files
rVYOSONEX912ffbfc78c3: broadcast-relay: T2230: move inlined templates to dedicated files
rVYOSONEXa1bb62adf227: flow-accounting: T2230: move inlined templates to dedicated files
rVYOSONEX013a9369bf2d: lldp: T2230: move inlined templates to dedicated files
rVYOSONEX870676f17138: snmp: T2230: move inlined templates to dedicated files
rVYOSONEX6a0d923e2ece: sstp: T2230: add Jinja2 trim_blocks Environment option
rVYOSONEXe6295b3334a8: ssh: T2230: add Jinja2 trim_blocks Environment option
rVYOSONEXea6fb514b0c6: l2tp: T2230: add Jinja2 trim_blocks Environment option
rVYOSONEX1f0f41db4495: dns-forwarding: T2230: move inlined templates to dedicated files
rVYOSONEX220f375b111b: dhcp-server: T2230: rename template dir from dhcp -> dhcp-server
rVYOSONEXa6100cde7c9f: dhcpv6-server: T2230: move inlined templates to dedicated files
rVYOSONEXa7c70fae028b: dhcpv6-relay: T2230: move inlined templates to dedicated files
rVYOSONEXf05c683cf1ff: ntp: T2230: fix wrong import statement
rVYOSONEXa39ae13ccc2a: dhcp-relay: T2230: move inlined templates to dedicated files
rVYOSONEXe66abf4117d2: sstp: T2230: move inlined templates to dedicated files
rVYOSONEX189b1fbabc17: dhcp: T2230: move inlined templates to dedicated files
rVYOSONEX579275e495a7: ntp: T2230: move inlined templates to dedicated files
rVYOSONEXbfc41f51ddc6: ssh: T2230: move inlined templates to dedicated files
rVYOSONEX0e3953fbed97: T2230: confert dos to unix line endings
rVYOSONEXcce97b217459: l2tp: T2230: move inlined templates to dedicated files

Event Timeline

c-po created this task.Apr 5 2020, 2:32 PM

c-po changed the task status from Open to In progress.

c-po claimed this task.

c-po edited a custom field.

c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.

c-po mentioned this in rVYOSONEXcce97b217459: l2tp: T2230: move inlined templates to dedicated files.Apr 5 2020, 2:40 PM

c-po mentioned this in rVYOSONEX0e3953fbed97: T2230: confert dos to unix line endings.Apr 5 2020, 2:49 PM

c-po mentioned this in rVYOSONEXbfc41f51ddc6: ssh: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX579275e495a7: ntp: T2230: move inlined templates to dedicated files.Apr 5 2020, 2:53 PM

c-po mentioned this in rVYOSONEX189b1fbabc17: dhcp: T2230: move inlined templates to dedicated files.Apr 5 2020, 3:10 PM

c-po mentioned this in rVYOSONEXe66abf4117d2: sstp: T2230: move inlined templates to dedicated files.Apr 5 2020, 3:16 PM

c-po mentioned this in rVYOSONEXa39ae13ccc2a: dhcp-relay: T2230: move inlined templates to dedicated files.Apr 5 2020, 4:10 PM

c-po mentioned this in rVYOSONEXf05c683cf1ff: ntp: T2230: fix wrong import statement.

c-po mentioned this in rVYOSONEXa7c70fae028b: dhcpv6-relay: T2230: move inlined templates to dedicated files.Apr 5 2020, 4:28 PM

c-po mentioned this in rVYOSONEXa6100cde7c9f: dhcpv6-server: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX220f375b111b: dhcp-server: T2230: rename template dir from dhcp -> dhcp-server.

c-po mentioned this in rVYOSONEX1f0f41db4495: dns-forwarding: T2230: move inlined templates to dedicated files.Apr 5 2020, 4:54 PM

c-po mentioned this in rVYOSONEXea6fb514b0c6: l2tp: T2230: add Jinja2 trim_blocks Environment option.

c-po mentioned this in rVYOSONEXe6295b3334a8: ssh: T2230: add Jinja2 trim_blocks Environment option.

c-po mentioned this in rVYOSONEX6a0d923e2ece: sstp: T2230: add Jinja2 trim_blocks Environment option.

c-po mentioned this in rVYOSONEX870676f17138: snmp: T2230: move inlined templates to dedicated files.Apr 5 2020, 5:43 PM

c-po mentioned this in rVYOSONEX013a9369bf2d: lldp: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEXa1bb62adf227: flow-accounting: T2230: move inlined templates to dedicated files.Apr 5 2020, 6:17 PM

c-po mentioned this in rVYOSONEX912ffbfc78c3: broadcast-relay: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX108979391c58: syslog: T2230: move inlined templates to dedicated files.Apr 5 2020, 6:28 PM

c-po mentioned this in rVYOSONEXc3770f57a322: dynamic-dns: T2230: move inlined templates to dedicated files.Apr 5 2020, 6:44 PM

c-po mentioned this in rVYOSONEXf69924cf4dae: igmp-proxy: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX272a738aa560: https: T2230: move inlined templates to dedicated files.Apr 5 2020, 7:25 PM

c-po mentioned this in rVYOSONEX578cb6efbc08: mdns-repeater: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX481bd0bfa9f3: tftp-server: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX166b86163824: bfd: T2230: move inlined templates to dedicated files.Apr 5 2020, 7:47 PM

c-po mentioned this in rVYOSONEX542cdf7b5e16: vrf: T2230: move inlined templates to dedicated files.Apr 5 2020, 7:54 PM

c-po mentioned this in rVYOSONEXbc848a8e62c3: mdns-repeater: T2230: convert template from dos to unix line endings.

c-po mentioned this in rVYOSONEX1556b15e9644: https: T2230: convert template from dos to unix line endings.

c-po mentioned this in rVYOSONEX6563f29bedb6: vrrp: T2230: convert template from dos to unix line endings.Apr 5 2020, 8:27 PM

c-po mentioned this in rVYOSONEX5171e61d9b30: system-login: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX5a04f7d6a9c4: wifi-regdom: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX3ea3c8ed6bd4: router-advert: T2230: move inlined templates to dedicated files.Apr 5 2020, 8:32 PM

c-po mentioned this in rVYOSONEX59cf7f59ac69: pptp: T2230: move inlined templates to dedicated files.Apr 5 2020, 8:40 PM

c-po mentioned this in rVYOSONEXebb54c107e30: pppoe-server: T2230: move inlined templates to dedicated files.Apr 5 2020, 8:48 PM

c-po mentioned this in rVYOSONEX839189228915: ipoe-server: T2230: move inlined templates to dedicated files.Apr 5 2020, 8:56 PM

c-po mentioned this in rVYOSONEXefe8eaa626a6: igmp: T2230: move inlined templates to dedicated files.Apr 5 2020, 9:02 PM

c-po mentioned this in rVYOSONEXda6883549b7e: mpls: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEX118681664310: pim: T2230: move inlined templates to dedicated files.Apr 5 2020, 9:21 PM

c-po mentioned this in rVYOSONEX6b4aed73cbb1: salt-minion: T2230: move inlined templates to dedicated files.

c-po mentioned this in rVYOSONEXdbc174dd2b85: ipsec: T2230: move inlined templates to dedicated files.

c-po closed this task as Resolved.Apr 5 2020, 9:22 PM

c-po triaged this task as Normal priority.

c-po edited a custom field.

c-po edited subscribers, added: Unknown Object (User); removed: c-po.

c-po mentioned this in rVYOSONEX10c06217a53b: ipsec: T2230: bugfix rewriting Jinja2 code.Apr 6 2020, 7:22 AM

c-po mentioned this in rVYOSONEX1730afc6ebb5: ipsec: T2230: bugfix code cleanup.Apr 6 2020, 8:48 AM

thomas-mangin mentioned this in T2265: DHCP to be an attribute of the class instead of a inheritance.Apr 11 2020, 12:18 PM

Restricted Repository Identity mentioned this in rVYOSONEX8978c7eaf4b1: Merge pull request #332 from thomas-mangin/T2230.Apr 12 2020, 7:08 PM

c-po mentioned this in rVYOSONEX152a147c3a34: ntp: T2230: fix wrong import after template migration.Apr 12 2020, 7:34 PM

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:24 PM

c-po mentioned this in rVYOSONEX6a957e7955b6: ssh: T2230: remove duplicated HostKey line.May 29 2020, 5:51 PM

pasik subscribed.May 29 2020, 7:31 PM

c-po mentioned this in rVYOSONEXca202f30fc5f: lldp: T2230: verify file exists before unlinking it.Jan 31 2021, 9:16 AM

c-po mentioned this in rVYOSONEX6c286fab17e8: lldp: T2230: verify file exists before unlinking it.

erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 7:38 AM

erkin removed a subscriber: Global Notifications.

Restricted Repository Identity mentioned this in rVYOSONEX90b9eeacfb62: Merge pull request #997 from c-po/nginx-tls-12-13.Sep 6 2021, 3:24 PM

c-po mentioned this in rVYOSONEX7546e249708d: https: T2230: only support TLS1.2 and TLS1.3.Sep 6 2021, 3:24 PM

jestabro mentioned this in rVYOSONEX424c08b6a871: https: T2230: only support TLS1.2 and TLS1.3.Sep 6 2021, 3:30 PM

c-po mentioned this in rVYOSONEXa0202eaf489c: igmp: T2230: fix Jinja2 and FRR indention.Sep 27 2021, 6:52 PM

c-po mentioned this in rVYOSONEX2974628487ab: dhcp-server: T2230: add subnet description into rendered config.Sep 30 2021, 6:41 PM

c-po mentioned this in rVYOSONEX51bdfc7e04b9: dhcp-server: T2230: add subnet description into rendered config.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.