Page MenuHomeVyOS Platform
Create Task
Maniphest T2230

Split out inlined Jina2 template to data/templates folder
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Back in the days when only small parts have been migrated to JInja2 the templates have been placed inside the Python file which did the configuration.

As more and more parts are getting migrated it has been found out that this sometimes super clutters the entire Python script.

Bad examples:

  • Wireless Interfaces (WIFI)
  • DHCP
  • Wireless Modem (multiple templates)

Thus all templates should be removed from the Python file and placed into the dedicates template folder to unclutter the Python configuration logic.

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

c-po changed the task status from Open to In progress.Apr 5 2020, 2:32 PM
c-po claimed this task.
c-po created this task.
c-po changed Difficulty level from Unknown (require assessment) to Hard (possibly days).
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po closed this task as Resolved.Apr 5 2020, 9:22 PM
c-po triaged this task as Normal priority.
c-po changed Difficulty level from Hard (possibly days) to Normal (likely a few hours).
c-po edited subscribers, added: Unknown Object (User); removed: c-po.
thomas-mangin mentioned this in T2265: DHCP to be an attribute of the class instead of a inheritance.Apr 11 2020, 12:18 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:24 PM
pasik added a subscriber: pasik.May 29 2020, 7:31 PM
erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 7:38 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.