Maniphest T2169

Remove redundant use of show_config in vyos-merge-config
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jestabro
	Mar 27 2020, 8:54 PM

Tags

Referenced Files

None

Subscribers

Description

In the rewrite of vyos-merge-config, the technique was used of passing output of showConfig into ConfigTree. This is now implicit in config.py in T1758; consequently there is a redundancy that can be removed.

Details

Version: vyso 1.3
Is it a breaking change?: Perfectly compatible
Issue type: Internal change (not visible to end users)

Related Objects

Mentioned In: rVYOSONEX792c00a018d0: Merge branch 't1831-ipv6' into current
rVYOSONEXf0b3da2b36b8: merge config: T2169: remove redundant use of show_config
Mentioned Here: T1758: Switch vyos.config to libvyosconfig

Event Timeline

jestabro created this task.Mar 27 2020, 8:54 PM

jestabro triaged this task as Normal priority.

jestabro created this object in space S1 VyOS Public.

jestabro mentioned this in rVYOSONEXf0b3da2b36b8: merge config: T2169: remove redundant use of show_config.Mar 27 2020, 9:10 PM

jestabro closed this task as Resolved.Mar 27 2020, 9:10 PM

c-po mentioned this in rVYOSONEX792c00a018d0: Merge branch 't1831-ipv6' into current.Mar 28 2020, 11:07 AM

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Apr 5 2020, 12:35 PM

erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 8:00 AM

erkin removed a subscriber: Global Notifications.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:03 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.