Page MenuHomeVyOS Platform

NTPd: Do not listen on all interfaces by default
Closed, ResolvedPublic

Description

NTPd should not listen on all interfaces by default, e.g. if the directive

set system ntp listen-address (IPv4|IPv6)

is not set. We should move the NTPd option interface ignore wildcard to the Non-configurable defaults section of ntp.py

--- src/conf_mode/ntp.py          2019-09-27 10:29:35.194814255 +0200
+++ src/conf_mode/ntp.py.new      2019-09-27 10:31:03.488701365 +0200
@@ -41,6 +41,8 @@
 restrict 127.0.0.1
 restrict -6 ::1

+# Do not listen on any interface address by default
+interface ignore wildcard

 #
 # Configurable section
@@ -63,8 +65,6 @@
 {% endif %}

 {% if listen_address -%}
-# NTP should listen on configured addresses only
-interface ignore wildcard
 {% for a in listen_address -%}
 interface listen {{ a }}
 {% endfor -%}

Details

Version
-
Is it a breaking change?
Behavior change

Event Timeline

syncer closed this task as Unknown Status.Nov 16 2019, 11:38 PM
syncer assigned this task to jestabro.
syncer triaged this task as Normal priority.
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
syncer moved this task from Needs Triage to Backlog on the VyOS 1.2 Crux (VyOS 1.2.4) board.
jestabro changed the task status from Unknown Status to Resolved.Nov 22 2019, 2:05 PM