Just noticed bridge has a member interface parameter now. The vif bridge-group config was not migrated.

After adding the vif to bridge member interfaces, I get a config load error on boot. Running config, load, commit, works. Something to do with the order the configs get applied?

The loading error is caused by bridging a l2tpv3 interface, didn't see the cause at first because of the other errors. Since the bridge is now created at priority 470, and l2tpv3 is 800, when before an interface would be added to the bridge as it is created.

Perhaps a fix could be changing it to
bridge brX member interface <type> <if>
with different priorities for the types?

Please share a pre and post-commit config block for me for testing.

You are right the VIF parts have been forgotten on the VIF interfaces

Not sure what you mean by pre and post-commit config blocks.

I can reproduce with minimal config on a freshly installed vm.

Config screenshot.. no network on it. https://i.imgur.com/A0mwPdI.png

Reboot - config error, bridge is missing. config/load/commit and the bridge is created.

Please add the config here as text so it can be easily extracted. Image hosting services tend to not store information forever.

Pre config: add configuration from VyOS (e.g. 1.2.2) which has the VIF interface added before upgrading to latest rolling. That one can be used in the lab to reproduce your problem exactly.

Reproducible via:

set interfaces bridge br100 address '192.168.100.254/24'
set interfaces bridge br200 address '192.168.200.254/24'
set interfaces ethernet eth3 vif 100 bridge-group bridge 'br100'
set interfaces ethernet eth3 vif 200 bridge-group bridge 'br200'

[email protected]# show interfaces bridge
 bridge br100 {
     address 192.168.100.254/24
 }
 bridge br200 {
     address 192.168.200.254/24
 }

[email protected]# show interfaces ethernet eth3
 duplex auto
 hw-id 00:53:00:00:00:01
 smp-affinity auto
 speed auto
 vif 100 {
     bridge-group {
         bridge br100
     }
 }
 vif 200 {
     bridge-group {
         bridge br200
     }
 }