Page MenuHomeVyOS Platform

Convert 'ping' operation from vyatta-op to new syntax
Closed, ResolvedPublic

Description

While the ping wrapper (with juniper-like options) seems trivial to rewrite in python, the node.def structure raises questions, so I'd like to hear some input from maintainers.
There is a 'recursive' symlinking of node.tag to itself, which makes a nice trick of 'infinite' options syntax possible:

~/dev/vyos/vyatta-op/templates/ping current
❯ tree .
.
├── node.def
└── node.tag
    ├── node.def
    └── node.tag
        ├── node.def
        └── node.tag -> ../node.tag/

What is the best way to approach that in new xml syntax?

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

alkersan triaged this task as Normal priority.Aug 21 2019, 6:41 AM
alkersan created this task.
alkersan created this object in space S1 VyOS Public.

@alkersan I think you need to create the link via Makefile in vyos-1x. At least I don't know of any possibility doing that within the xml.

@hagbard this is a great idea - I did not thought about it.

c-po claimed this task.
c-po set Is it a breaking change? to Unspecified (possibly destroys the router).