Page MenuHomeVyOS Platform
Create Task
Maniphest T1394

syslog systemd and host_name.py race condition
Closed, ResolvedPublicBUG
Actions

Description

May 21 22:40:23 pppoe-server systemd[1]: rsyslog.service start request repeated too quickly, refusing to start.
May 21 22:40:23 pppoe-server systemd[1]: Failed to start System Logging Service.
May 21 22:40:23 pppoe-server systemd[1]: Unit rsyslog.service entered failed state.

It is started via vyos-router config since the config prepares the rsyslog config file.

Details

Difficulty level
Easy (less than an hour)
Version
1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Related Objects
Search...

Event Timeline

hagbard created this task.May 21 2019, 10:47 PM
pasik added a subscriber: pasik.May 23 2019, 6:51 AM
hagbard claimed this task.May 23 2019, 7:32 PM
hagbard added a comment.Jun 17 2019, 4:53 PM

start via systemd is required, otherwise if disabled systemd dependency craps out.

hagbard added a comment.Jun 17 2019, 5:02 PM

Jun 17 16:57:53 vyos sudo[1417]: root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/usr/libexec/vyos/conf_mode/host_name.py
Jun 17 16:57:53 vyos sudo[1417]: pam_unix(sudo:session): session opened for user root by (uid=0)
Jun 17 16:57:53 vyos systemd[1]: Stopping System Logging Service...

Jun 17 16:57:53 vyos systemd[1]: Starting System Logging Service...

Jun 17 16:57:53 vyos systemd[1]: rsyslog.service start request repeated too quickly, refusing to start.
Jun 17 16:57:53 vyos systemd[1]: Failed to start System Logging Service.

Jun 17 16:57:53 vyos systemd[1]: Unit syslog.socket entered failed state.
Jun 17 16:57:53 vyos systemd[1]: Unit rsyslog.service entered failed state.

Looks like an issue with calling the hostname.py script.

hagbard added a comment.Jun 17 2019, 5:05 PM

host_name.py has "os.system("systemctl restart rsyslog.service")" which causes the race condition at boot time.

hagbard renamed this task from syslog is being started via systemd and should not to syslog systemd and host_name.py race condition.Jun 17 2019, 6:06 PM
hagbard closed this task as Resolved.Jun 17 2019, 6:12 PM

https://github.com/vyos/vyos-1x/commit/0f354688d7bd63b63fb91faf17a38c77fb05f660

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Jun 23 2019, 5:46 PM
dmbaturin added a subtask: T1447: Python subprocess called without import in host_name.py.Nov 5 2019, 12:59 PM
dmbaturin added a project: VyOS 1.2 Crux (VyOS 1.2.4).Nov 5 2019, 1:02 PM
dmbaturin set Is it a breaking change? to Unspecified (possibly destroys the router).
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.Nov 17 2019, 12:02 AM
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:26 PM