- doesn't check if a change is required to write to file. set system static-host-mapping has tag nodes, resolv.conf gets rewritten multiple times even if there is no change in resolv.conf required
- add ....
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- -
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Unspecified (possibly destroys the router)
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | dmbaturin | T1598 New implementation of the resolv.conf and hosts update mechanism | |||
Resolved | FEATURE REQUEST | dmbaturin | T1264 /usr/libexec/vyos/conf_mode/host_name.py improvments |
Event Timeline
Comment Actions
if host-name is not set and an IP is given to an interface script causes a an exception - maybe a default hostname could be set if the option is not in config.boot. Happens if you wipe config.boot and reboot. The default one won't have host-name configured and assigning IPs to interface still work but produce that nasty exception.
Comment Actions
When a host-name is not present, set the same default as on a newly installed device... router or vyos.. (atm. i don't remember what it says)
Comment Actions
I think vyos is the default, so I'll weave it into host_name.py as a default if not present in the default config.boot. Not sure why there is that difference, but on the other hand the script should and can handle missing variables.
Comment Actions
- checks now for the existence of variables instead of overwriting the predefined defaults (https://github.com/vyos/vyos-1x/commit/99b2bfc74f30987d00384e384e8caa4fad28528b#diff-393bdd2f2828daf4f3a67bc8b46fcce9)