Change Details

Actually, while using raise ConfigError() during configuration parsing, it executes and exception and prints it. While trying to append all error found in certain config section, it's imposible to print all of them in readble format. For example, while testing this on new feature: ``` error_output = [] error_output.append('Fail to apply firewall') for ... (look for errors) error_output.append(f'Error found on: firewall {family} {chain} {parsed_entries[2]} rule {parsed_entries[3]}') error_output.append(f'\tError message: {error_message.strip()}') # Generate string: message = '\n'.join(error_output) print("##") print(message) print("##") raise ConfigError(f'{message}') ``` Testing and commit shows appropriate formatting for variable **//message//** but **//ConfigError//** gets different output: ``` vyos@BRIDGE# commit ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6 Error found on: firewall bridge input filter rule 10 Error message: fanout requires a range to be specified ## firewall: ConfigError('Fail to apply firewall Error found on: firewall bridge forward filter\nrule 1 Error message: conflicting protocols specified: ip vs.\nip6 Error found on: firewall bridge input filter rule 10 Error\nmessage: fanout requires a range to be specified') [[firewall]] failed Commit failed [edit] vyos@BRIDGE# ``` Also, while stopping //**vyos-configd**//, output for //ConfigError// is also different: ``` vyos@BRIDGE# commit [ firewall ] ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6 Error found on: firewall bridge input filter rule 10 Error message: fanout requires a range to be specified ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6 Error found on: firewall bridge input filter rule 10 Error message: fanout requires a range to be specified [[firewall]] failed Commit failed [edit] vyos@BRIDGE# ```

For some reason `ConfigError()` exception behavior is wrong when a configuration session uses `vyos-configd`. Instead of executing an exception, it shows it. This breaks error message formatting, and potentially also can affect error handling in general. ### How to reproduce ``` set interfaces vxlan vxlan1 description 'this is strange' commit ``` Error with running `vyos-configd`: ``` vyos@vyos# commit interfaces_vxlan: ConfigError('Group, remote, source-address or source-interface must be configured') [[interfaces vxlan vxlan1]] failed Commit failed ``` Error with stopped `vyos-configd`: ``` vyos@vyos# commit [ interfaces vxlan vxlan1 ] Group, remote, source-address or source-interface must be configured [[interfaces vxlan vxlan1]] failed Commit failed ```

Actually,For some reason `ConfigError()` exception behavior is wrong when a configuration session uses `vyos-configd`. while using raise ConfigError() durInstead of executing configuration parsingan exception, it executes and exception and printit shows it. While trying to append allThis breaks error found in certain config sectionmessage formatting, it's imposible to print all of them in readble formatand potentially also can affect error handling in general. For example, while testing this on new feature:### How to reproduce ``` error_output = []set interfaces vxlan vxlan1 description 'this is strange' error_output.append('Fail to apply firewall')commit for ... (look for errors) error_output.append(f'Error found on: firewall {family} {chain} {parsed_entries[2]} rule {parsed_entries[3]}') error_output.append(f'\tError message: {error_message.strip()}') # Generate string: message = '\n'.join(error_output) print("##") print(message) print("##") raise ConfigError(f'{message}') ``` Testing and commit shows appropriate formatt Error with running for variable **//message//** but **//C`vyos-configError//** gets different output:gd`: ``` vyos@BRIDGE# commit ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6 Error found on: firewall bridge input filter rule 10 Error message: fanout requires a range to be specified ##vyos# commit firewall: ConfigError('Fail to apply firewall Error found on: firewall bridge forward filter\nrule 1 Error message: conflicting protocols specified: ip vs.\nip6 Error found on: firewall bridge input filter rule 10 Error\nmessage: fanout requires a range to be specifiinterfaces_vxlan: ConfigError('Group, remote, source-address or source-interface must be configured') [[firewallinterfaces vxlan vxlan1]] failed Commit failed [edit] vyos@BRIDGE# ``` Also, whileError with stopping //**ed `vyos-configd**//, output for //ConfigError// is also different:d`: ``` vyos@BRIDGE# commit [ firewall ] ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6vyos# commit Error found on: firewall bridge input filter rule 10[ interfaces vxlan vxlan1 ] Error message: fanout requires a range to be specified ## Fail to apply firewall Error found on: firewall bridge forward filter rule 1 Error message: conflicting protocols specified: ip vs. ip6 Error found on: firewall bridge input filter rule 10 Error message: fanout requires a range to be specifiGroup, remote, source-address or source-interface must be configured [[firewallinterfaces vxlan vxlan1]] failed Commit failed [edit] vyos@BRIDGE# ```