`ConfigError()` behavior is wrong with running `vyos-configd`
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	n.fort
	Jul 24 2024, 12:22 PM

Description

For some reason ConfigError() exception behavior is wrong when a configuration session uses vyos-configd. Instead of executing an exception, it shows it.

This breaks error message formatting, and potentially also can affect error handling in general.

How to reproduce

set interfaces vxlan vxlan1 description 'this is strange'
commit

Error with running vyos-configd:

vyos@vyos# commit

interfaces_vxlan: ConfigError('Group, remote, source-address or source-interface must be configured')

[[interfaces vxlan vxlan1]] failed
Commit failed

Error with stopped vyos-configd:

vyos@vyos# commit
[ interfaces vxlan vxlan1 ]
Group, remote, source-address or source-interface must be configured

[[interfaces vxlan vxlan1]] failed
Commit failed

Details

Difficulty level: Easy (less than an hour)
Version: 1.5-rolling-202407171706
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Related Objects

Mentioned In: T6608: configd should report exceptions uncaught by conf_mode scripts as commit error

Event Timeline

n.fort created this task.Jul 24 2024, 12:22 PM

zsdc renamed this task from ConfigError() not parsing data as expected or needed to `ConfigError()` behavior is wrong with running `vyos-configd`.Jul 24 2024, 12:37 PM

zsdc changed the task status from Open to Confirmed.

zsdc updated the task description. (Show Details)

This was a result of changes to make error reporting more explicit in case of errors in config dependencies; I will realign with error reporting without vyos-configd.

pasik subscribed.Jul 24 2024, 3:28 PM

jestabro triaged this task as Normal priority.Jul 24 2024, 3:32 PM

jestabro changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).

Note that this is only a difference in formatting, not a change in error reporting; the formatting will be restored to the original behavior for consistency of parsing.

PR:
https://github.com/vyos/vyos-1x/pull/3868

jestabro added a project: VyOS 1.4 Sagitta (1.4.1).Jul 24 2024, 4:30 PM

jestabro mentioned this in T6608: configd should report exceptions uncaught by conf_mode scripts as commit error.Jul 25 2024, 1:21 PM

jestabro moved this task from Need Triage to Backport Candidates on the VyOS 1.5 Circinus board.Jul 25 2024, 1:54 PM

jestabro moved this task from Need Triage to Backport Candidates on the VyOS 1.4 Sagitta (1.4.1) board.

jestabro closed this task as Resolved.Jul 28 2024, 11:16 PM

jestabro moved this task from Backport Candidates to Finished on the VyOS 1.5 Circinus board.

jestabro moved this task from Backport Candidates to Finished on the VyOS 1.4 Sagitta (1.4.1) board.