HomeVyOS Platform

vrf: T6602: verify supplied VRF name on all interface types (#3870)

This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

vrf: T6602: verify supplied VRF name on all interface types (#3870)

Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF
actually exists. If this is not validated, one can pass an invalid VRF to the
system which generates an OSError exception.

To reproduce

set interfaces vxlan vxlan1 vni 1000
set interfaces vxlan vxlan1 remote 1.2.3.4
set interfaces vxlan vxlan1 vrf smoketest

results in

OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt

This commit adds the missing verify_vrf() call to the missing interface types
and an appropriate smoketest for all interfaces supporting VRF assignment.

(cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359)

Co-authored-by: Christian Breunig <christian@breunig.cc>

Details

Provenance
mergify[bot]Authored on Jul 25 2024, 2:48 AM
GitHubCommitted on Jul 25 2024, 2:48 AM
Parents
rVYOSONEX8fa7de187c32: Merge pull request #3867 from vyos/mergify/bp/circinus/pr-3861
Branches
Loading...
Tags
Loading...

Event Timeline

GitHub <noreply@github.com> committed rVYOSONEX67695c3e7a0d: vrf: T6602: verify supplied VRF name on all interface types (#3870) (authored by mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>).Jul 25 2024, 2:48 AM