HomeVyOS Platform
Diffusion vyos-1x 3400b1dd7970

T1762: adjust the set_level() calls to use the new list representation.
3400b1dd7970
Actions

Description

T1762: adjust the set_level() calls to use the new list representation.

Details

Provenance
dmbaturinAuthored on Oct 24 2019, 9:33 AM
Parents
rVYOSONEX8bf1b924055c: [vyos.config] T1764: support both string and list arguments in config functions.
Branches
Loading...
Tags
Loading...

Event Timeline

dmbaturin committed rVYOSONEX3400b1dd7970: T1762: adjust the set_level() calls to use the new list representation. (authored by dmbaturin).Oct 24 2019, 9:33 AM
varesa subscribed.Dec 3 2019, 10:03 PM
varesa added inline comments.
/src/conf_mode/interfaces-ethernet.py
133

This doesn't seem like it belong here, see T1844

varesa mentioned this in T1762: VLAN interface configuration fails after internal representation of edit level was switched from a string to a list.Dec 3 2019, 10:05 PM
varesa added inline comments.Dec 4 2019, 11:32 AM
/src/conf_mode/interfaces-ethernet.py
133

Okay, it turns out that config.exists() *almost* supports both strings and lists. Maybe the wanted fix is there instead

Changes (2)

PathSize
python/
vyos/
src/
conf_mode/

rVYOSONEX3400b1dd7970

View Options

python/vyos/configdict.py

Loading...
View Options

src/conf_mode/interfaces-ethernet.py

Loading...