Page MenuHomeVyOS Platform

neilmckee (Neil McKee)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2023, 8:55 PM (57 w, 2 h)

Recent Activity

Apr 3 2023

neilmckee added a comment to T5125: Add op-mode commands for hsflowd based sflow.

Yes. Packet drops are classed as "event_samples" internally. Definitions for telemetry counters are here:
https://github.com/sflow/host-sflow/blob/v2.0.50-4/src/Linux/hsflowd.h#L460-L486

Apr 3 2023, 4:14 PM · VyOS 1.4 Sagitta

Apr 1 2023

neilmckee added a comment to T5125: Add op-mode commands for hsflowd based sflow.

The packet-drop events are not really samples in the same way as the packets are random-samples and the counters are time-samples. Even if there is only 1 dropped packet it will be sent. So it might be better to change the wording from “Samples drop events sent” to something like “Packet drop events sent” or just “Packet drops sent”. Make sense?

Apr 1 2023, 9:29 PM · VyOS 1.4 Sagitta
neilmckee added a comment to T5125: Add op-mode commands for hsflowd based sflow.

Apologies. I believe it is corrected now.

Apr 1 2023, 3:37 PM · VyOS 1.4 Sagitta

Mar 31 2023

neilmckee added a comment to T5125: Add op-mode commands for hsflowd based sflow.

I think there should be one more metric - the number of packet-drop-events sent. I just checked in a change that adds to the example telemetry.py script:
https://github.com/sflow/host-sflow/commit/5b01779abf21a7553e07188ff2f54850c568f786

Mar 31 2023, 5:56 PM · VyOS 1.4 Sagitta

Mar 29 2023

neilmckee added a comment to T5125: Add op-mode commands for hsflowd based sflow.

Starting in hsflowd version 2.0.50-3, the mod_dbus module can be asked for the current sFlow agent-address along with other stats, and the example "telemetry" and "telemetry.py" scripts in the repo under src/Linux/scripts/ have both been updated. So if you wanted to offer a "show sflow" CLI command then you might adapt one or other of those scripts to extract the information from the running hsflowd process. The steps would be:

Mar 29 2023, 8:56 PM · VyOS 1.4 Sagitta