User Details
- User Since
- Nov 28 2021, 3:45 AM (158 w, 2 d)
Tue, Nov 12
Upon review, I don't think that this is still an issue any longer in the current rolling release. When saving the config, the effective/running config tree is fetched instead of the session config, and so the incomplete session configuration is not written to disk. The vyatta-bash package also provides a "Warning: you have uncommitted changes that will not be saved." message now when the session has non-committed configuration.
Mon, Nov 11
Thank you, this is my first actual contribution so please feel free let me know if this approach isn't the way you want to do it. If you point me in the right direction, I will implement it however you suggest. I mostly searched the source for other situations where VyOS asks this type of question and copied the idea.
If this could be assigned to me, I am working on a patch that will prompt with ask_yes_no when session_changed() is true of the config, warning the user that the configuration has uncommitted changes and saving it may result in failure to load config on boot.