Page MenuHomeVyOS Platform

Improve pylint coverage accross entire vyos-1x repository
Open, HighPublicBUG

Description

On circinus, the T9474 backport added src/helpers/vyos-nft-time-refresh.py. It imports acquire_commit_lock_file and release_commit_lock_file from vyos.utils.commit. Those two functions only exist on rolling, where they came with T7365.

Running pylint's error check on the file by hand reports it at once:

src/helpers/vyos-nft-time-refresh.py:34:0: E0611: No name 'acquire_commit_lock_file' in module 'vyos.utils.commit' (no-name-in-module)
src/helpers/vyos-nft-time-refresh.py:35:0: E0611: No name 'release_commit_lock_file' in module 'vyos.utils.commit' (no-name-in-module)

This was not detected by the Pylint setup which must be fixed and extended to cover all remaining files which were missed before.

Details

Version
rolling, 1.5.2, scutum
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)