Page MenuHomeVyOS Platform

Skip accel-ppp service restart for non-client-impacting L2TP config changes
Open, NormalPublicFEATURE REQUEST

Description

Currently, any change under L2TP settings triggers a full restart of the accel-ppp service, forcing all connected clients to disconnect and reconnect — even when the change is unrelated to client sessions (e.g., discription, enabling SNMP or syslog). Request is to make accel-ppp restart conditional, only occurring when the modified setting actually affects client connections, so unrelated changes can apply without disrupting existing sessions.

Log reference:

Aug 14 07:34:26 systemd[1]: Starting Accel-PPP - High performance VPN server application for Linux...
Aug 14 07:34:26 systemd[1]: Started Accel-PPP - High performance VPN server application for Linux.
Aug 14 07:34:26 accel-l2tp[4389]: l2tp: iprange module disabled, improper IP configuration of PPP interfaces may cause kernel soft lockup
Aug 14 07:41:31 accel-l2tp[4389]: l2tp: new tunnel 31351-1 created following reception of SCCRQ from 192.0.2.20:1701
Aug 14 07:41:31 accel-l2tp[4389]: l2tp tunnel 31351-1 (192.0.2.20:1701): established at 192.0.2.1:1701
Aug 14 07:41:31 accel-l2tp[4389]: l2tp tunnel 31351-1 (192.0.2.20:1701): new session 6069-1 with calling num (null) len 0, called num (null) len 0 created following reception of ICRQ
Aug 14 07:41:34 accel-l2tp[4389]: ppp0:test: connect: ppp0 <--> l2tp(192.0.2.20:1701 session 31351-1, 6069-1)
Aug 14 07:41:34 accel-l2tp[4389]: ppp0:test: test: authentication succeeded
Aug 14 07:41:34 accel-l2tp[4389]: ppp0:test: IPV6CP: discarding packet
Aug 14 07:41:34 accel-l2tp[4389]: l2tp0:test: session started over l2tp session 31351-1, 6069-1
Aug 14 07:44:42 systemd[1]: Stopping Accel-PPP - High performance VPN server application for Linux...
Aug 14 07:44:42 accel-l2tp[4389]: terminate, sig = 15
Aug 14 07:44:42 accel-l2tp[4389]: l2tp session 31351-1, 6069-1: data channel closed, disconnecting session
Aug 14 07:44:42 accel-l2tp[4389]: l2tp tunnel 31351-1 (192.0.2.20:1701): no more session, disconnecting tunnel
Aug 14 07:44:42 accel-l2tp[4389]: l2tp tunnel 31351-1 (192.0.2.20:1701): context thread is closing, disconnecting tunnel
Aug 14 07:44:43 systemd[1]: accel-ppp@l2tp.service: Deactivated successfully.
Aug 14 07:44:43 systemd[1]: Stopped Accel-PPP - High performance VPN server application for Linux.
Aug 14 07:44:43 systemd[1]: Starting Accel-PPP - High performance VPN server application for Linux...
Aug 14 07:44:43 systemd[1]: Started Accel-PPP - High performance VPN server application for Linux.

Details

Version
1.5
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Related Objects