Page MenuHomeVyOS Platform
Create Task
Maniphest T7858

PPPoE: extend smoketests to test connection
Closed, ResolvedPublicBUG
Actions

Description

As we ship a full blow PPPoE/BRAS server in VyOS we can leverage this to test PPPoE connections.

Test should cover the dial-in and interface creation as well as IPv4 defsult eoute creation.

A subsequent benefit is an extended test for IPv6 (incl. PD) assignment

Details

Version
rolling
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

c-po created this task.Sep 24 2025, 6:47 AM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po added a project: VyOS 1.4 Sagitta (1.4.4).
c-po added a comment.Sep 30 2025, 2:28 PM

https://github.com/vyos/vyos-1x/pull/4760

c-po mentioned this in rVYOSONEX2c521f135637: smoketest: T7858: make failfast main argument dynamic.Sep 30 2025, 7:48 PM
c-po mentioned this in rVYOSONEX75e9fd60c553: smoketest: T7858: add PPPoE client tests with IPv4, IPv6 and DHCPv6-PD.
c-po mentioned this in rVYOSONEXfa868a6967b5: smoketest: T7858: use pylint for our testcases.
Restricted Repository Identity mentioned this in rVYOSONEX83882a3c8015: Merge pull request #4760 from c-po/pppoe-client-smoketests.Sep 30 2025, 7:48 PM
Viacheslav subscribed.EditedOct 7 2025, 9:33 AM

Smoketest fails

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_interfaces_pppoe.py
DEBUG - test_pppoe_authentication (__main__.PPPoEInterfaceTest.test_pppoe_authentication) ... ok
DEBUG - test_pppoe_client (__main__.PPPoEInterfaceTest.test_pppoe_client) ... FAIL
DEBUG - test_pppoe_client_disabled_interface (__main__.PPPoEInterfaceTest.test_pppoe_client_disabled_interface) ... ok
DEBUG - test_pppoe_dhcpv6pd (__main__.PPPoEInterfaceTest.test_pppoe_dhcpv6pd) ... ok
DEBUG - test_pppoe_mtu_mru (__main__.PPPoEInterfaceTest.test_pppoe_mtu_mru) ... ok
DEBUG - test_pppoe_options (__main__.PPPoEInterfaceTest.test_pppoe_options) ... ok
DEBUG -
DEBUG - ======================================================================
DEBUG - FAIL: test_pppoe_client (__main__.PPPoEInterfaceTest.test_pppoe_client)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG -   File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_pppoe.py", line 179, in test_pppoe_client
DEBUG -     self.assertTrue(any(iface == interface for (iface, _) in tmp))
DEBUG - AssertionError: False is not true
DEBUG -
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 6 tests in 77.628s

log

Oct 07 12:36:52 r14 staticd[2000]: [PNYPZ-BCP8Y] Static Route using pppoe20 interface not installed because the interface does not exist in specified vrf
Unknown Object (User) closed this task as Resolved.Oct 9 2025, 5:18 PM
Unknown Object (User) removed a project: VyOS 1.4 Sagitta (1.4.4).
Unknown Object (User) moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Unknown Object (User) moved this task from Need Triage to Completed on the VyOS Rolling board.
c-po mentioned this in rVYOSONEXb221b50a444c: smoketest: T7858: add helper to PPPoE tests to calculate IPv6 address from PD.Oct 16 2025, 3:18 PM
c-po mentioned this in rVYOSONEX30ff9cfc3dbe: smoketest: T7858: make config save test failfast main argument dynamic.Oct 22 2025, 3:10 AM
c-po mentioned this in rVYOSONEX156ff1849d58: smoketest: T7858: make failover route testcases failfast main argument dynamic.
c-po mentioned this in rVYOSONEX75e235563dfe: smoketest: T7858: temporary disable PPPoE client smoketests.
dmbaturin edited projects, added VyOS 1.5 Circinus (2025.11); removed VyOS 1.5 Circinus (1.5-stream-2025-Q3), VyOS Rolling.Wed, Nov 12, 5:59 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Bug (incorrect behavior) to Internal change (not visible to end users).