Page MenuHomeVyOS Platform
Create Task
Maniphest T7648

Set up a linter check to check complete files for syntax errors and missing imports
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Summary

Now we don’t run any check against the whole file and in two cases missing import slipped in. We should try to prevent those simple errors before the PR makes it to the review stage.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Revisions and Commits

Restricted Diffusion Commit
Restricted Diffusion Commit
rVYOSONEX vyos-1x
rVYOSONEX135c2d392090 Merge pull request #4615 from c-po/t7648-Makefile-fix

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
c-po mentioned this in rVYOSONEXc9f7684c107e: op-mode: T7648: add missing import statement in connect disconnect handler.Jul 22 2025, 2:05 PM
c-po mentioned this in rVYOSONEX1e4cc0806435: op-mode: pki: T7648: fix pylint error.
c-po mentioned this in rVYOSONEX32d5bbaa006f: op-mode: T7648: fix pylint errors in storage module.
c-po mentioned this in rVYOSONEXf6e25c242bd4: vyos.utils: T7648: only provide one chown function.
c-po mentioned this in rVYOSONEXdc06f6ff6e98: vyos.utils: T7648: remove duplicate definition of makedir.
c-po mentioned this in rVYOSONEX5f3485d44151: vyos.utils: T7648: fix missing import for ConfigError.
c-po mentioned this in rVYOSONEXef3ed4feae0a: vyos.utils: T7648: fix undefined variable in install_into_config.
c-po mentioned this in rVYOSONEX1dc4f02a6c51: T7648: enable pylint target for "make all" to check for e.g. missing imports.
c-po mentioned this in rVYOSONEX8c4ddd1e6c9a: migration: T7648: fix Undefined variable 'base' in interfaces/0-to-1.
c-po mentioned this in rVYOSONEXf1967db6c12e: migration: T7648: fix Undefined variable 'config' in interfaces/5-to-6.
c-po mentioned this in rVYOSONEX1b572eddf786: migration: T7648: fix Undefined variable 'af_path' in quagga/2-to-3.
c-po mentioned this in rVYOSONEX78c21d260127: migration: T7648: fix Undefined variable 'config' in vrrp/1-to-2.
c-po mentioned this in rVYOSONEXb7a24e7f4945: T7648: enable pylint for both migration-scripts and custom daemons (services).
Restricted Repository Identity mentioned this in rVYOSONEXdea50dfb0ded: Merge pull request #4613 from c-po/add-pylint.Jul 22 2025, 2:05 PM
c-po mentioned this in rVYOSONEXfcc5e8614a0e: T7648: pylint depends on XML cache generated in interface_definitions.Jul 22 2025, 2:40 PM
Restricted Repository Identity closed this task as Resolved by committing rVYOSONEX135c2d392090: Merge pull request #4615 from c-po/t7648-Makefile-fix.Jul 22 2025, 2:40 PM
Restricted Repository Identity added a commit: rVYOSONEX135c2d392090: Merge pull request #4615 from c-po/t7648-Makefile-fix.
Restricted Repository Identity added a commit: Restricted Diffusion Commit.
c-po mentioned this in rVYOSONEX50ecd71cb7f8: pylint: T7648: disable some linter-checks hit by GitHub action pipeline.Jul 24 2025, 2:29 PM
Restricted Repository Identity mentioned this in rVYOSONEXfca865d3e112: Merge pull request #4620 from vyos/lint-fix.Jul 24 2025, 2:29 PM
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.Jul 28 2025, 9:16 AM
c-po moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.4) board.
c-po mentioned this in T7590: cli: define a helper that generates a list of ALL available op-mode commands to embed in smoketesting.
Restricted Repository Identity added a commit: Restricted Diffusion Commit.Jul 29 2025, 5:44 PM
pasik subscribed.Aug 19 2025, 9:51 AM
dmbaturin edited projects, added VyOS 1.5 Circinus (2025.11); removed VyOS 1.4 Sagitta (1.4.4), VyOS 1.5 Circinus (1.5-stream-2025-Q3), VyOS Rolling.Thu, Nov 13, 2:36 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Feature (new functionality) to Internal change (not visible to end users).