Page MenuHomeVyOS Platform
Create Task
Maniphest T7511

Unable to apply OpenConnect RADIUS accounting settings
Closed, ResolvedPublicBUG
Actions

Description

Hi,
There is misspelling on https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/vpn_openconnect.py#L82.
Should be

if not ocserv["accounting"] .....

instead of

if not origin["accounting"] .....

Details

Version
VyOS 2025.06.01-0024-rolling
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

red55 created this task.Jun 1 2025, 8:36 AM
red55 updated the task description. (Show Details)
pasik subscribed.Jun 1 2025, 10:31 AM
Viacheslav subscribed.Jun 2 2025, 9:11 AM

Thanks @red55
Would you like to create a PR to fix this?

Viacheslav triaged this task as Normal priority.Jun 2 2025, 9:11 AM
red55 added a comment.EditedJun 2 2025, 11:22 AM
In T7511#225850, @Viacheslav wrote:

Thanks @red55
Would you like to create a PR to fix this?

Yes, sure. @Viacheslav, guide me how, please.

Viacheslav added a comment.Jun 2 2025, 11:29 AM

Fork the repo vyos-1x do your changes and create a PR, there are several open PR's for example https://github.com/vyos/vyos-1x/pulls
Refer to the task number T7511 in the commit message and PR header.

red55 claimed this task.Jun 2 2025, 11:31 AM

Thanks, will do.

red55 added a comment.Jun 2 2025, 3:17 PM

@Viacheslav done - https://github.com/vyos/vyos-1x/pull/4540

c-po added projects: VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS 1.4 Sagitta (1.4.3).Jun 2 2025, 8:01 PM
red55 mentioned this in rVYOSONEX7b2bf746a36b: openconnect: T7511: Correct variable name in accounting checks block.Jun 3 2025, 2:57 PM
red55 mentioned this in rVYOSONEX44ad57f793c8: openconnect: T7511: fix ruff warnings.
red55 mentioned this in rVYOSONEX67fc642c4b08: openconnect: T7511: ruff format.
Restricted Repository Identity mentioned this in rVYOSONEX1617e9fcb342: Merge pull request #4540 from red55/current.Jun 3 2025, 2:57 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.Jul 9 2025, 1:03 PM
dmbaturin moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q2) board.Jul 9 2025, 1:23 PM
dmbaturin closed this task as Resolved.Jul 14 2025, 6:51 PM
dmbaturin moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.3) board.
dmbaturin moved this task from Need Triage to Completed on the VyOS Rolling board.
dmbaturin mentioned this in 1.4.3.Jul 17 2025, 8:18 AM