Maniphest T7042

Drop requirement of importing script in build time test test_configd_inspect.py
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	jestabro
	Sat, Jan 11, 4:27 AM

Tags

Referenced Files

None

Subscribers

Description

Using the inspect module on the imported config-mode scripts requires importing dependencies into the environment, which may be inconvenient. As the use of the inspect module was simply a manner to getsource/signature, rewrite with ast module.

Details

Version: -
Is it a breaking change?: Perfectly compatible
Issue type: Internal change (not visible to end users)

Related Objects

Mentioned In: rVYOSONEX8a83a976b775: Merge pull request #4300 from jestabro/configd-inspect-by-ast
rVYOSONEXd5b1bfc7c900: T7042: drop use of inspect module in favor of ast for source analysis

Event Timeline

jestabro created this task.Sat, Jan 11, 4:27 AM

jestabro triaged this task as Normal priority.

PR:
https://github.com/vyos/vyos-1x/pull/4300

pasik subscribed.Sat, Jan 11, 6:59 AM

jestabro closed this task as Resolved.Sat, Jan 11, 2:00 PM

jestabro moved this task from Need Triage to Backport Candidates on the VyOS Rolling board.

jestabro mentioned this in rVYOSONEXd5b1bfc7c900: T7042: drop use of inspect module in favor of ast for source analysis.Sat, Jan 11, 2:01 PM

Restricted Repository Identity mentioned this in rVYOSONEX8a83a976b775: Merge pull request #4300 from jestabro/configd-inspect-by-ast.Sat, Jan 11, 2:01 PM