Page MenuHomeVyOS Platform

[QoS] Policy Limiter class match filter is duplicated
Open, LowPublicBUG

Description

Sometimes the filter is duplicated

step to reproduce:

vyos@vyos# run show configuration commands | grep qos
set qos interface eth1 ingress 'test'
set qos policy limiter test class 10 bandwidth '10gbit'
set qos policy limiter test class 10 match test_match ip dscp 'network'
set qos policy limiter test default bandwidth '100mbit'
vyos@vyos# tc -d filter show dev eth1 ingress
filter parent ffff: protocol all pref 20 u32 chain 0 
filter parent ffff: protocol all pref 20 u32 chain 0 fh 800: ht divisor 1 
filter parent ffff: protocol all pref 20 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 flowid ffff:a not_in_hw 
  match 00e00000/00ff0000 at 0
filter parent ffff: protocol all pref 20 u32 chain 0 fh 800::801 order 2049 key ht 800 bkt 0 flowid ffff:a not_in_hw 
  match 00e00000/00ff0000 at 0
        action order 1:  police 0x1 rate 10Gbit burst 13750b mtu 2Kb action drop overhead 0b linklayer ethernet 
        ref 1 bind 1 

filter parent ffff: protocol all pref 255 basic chain 0 
filter parent ffff: protocol all pref 255 basic chain 0 handle 0x1 flowid ffff:b 
        action order 1:  police 0x2 rate 100Mbit burst 15337b mtu 2Kb action drop overhead 0b linklayer ethernet 
        ref 1 bind 1

but on vyos 1.3 with the same config we have:

vyos@vyos# run show configuration commands | grep traf
set interfaces ethernet eth1 traffic-policy in 'test'
set traffic-policy limiter test class 10 bandwidth '10gbit'
set traffic-policy limiter test class 10 match test_match ip dscp 'network'
set traffic-policy limiter test default bandwidth '100mbit'
[edit]
vyos@vyos# tc -d filter show dev eth1 ingress
filter parent ffff: protocol all pref 20 u32 chain 0 
filter parent ffff: protocol all pref 20 u32 chain 0 fh 800: ht divisor 1 
filter parent ffff: protocol all pref 20 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 flowid ffff:a not_in_hw 
  match 00e00000/00ff0000 at 0
        action order 1:  police 0x1 rate 10Gbit burst 13750b mtu 2Kb action drop overhead 0b linklayer ethernet 
        ref 1 bind 1

filter parent ffff: protocol all pref 255 basic chain 0 
filter parent ffff: protocol all pref 255 basic chain 0 handle 0x1 flowid ffff:b 
        action order 1:  police 0x2 rate 100Mbit burst 15337b mtu 2Kb action drop overhead 0b linklayer ethernet 
        ref 1 bind 1

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4.1-beta1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

HollyGurza changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
HollyGurza changed the subtype of this task from "Task" to "Bug".