Page MenuHomeVyOS Platform

Move commands that do not fit anywhere else in the new "execute" family
In progress, NormalPublic

Description

We have multiple operational mode commands that could be described as "execute an action that has nothing to do with the system state and wouldn't be automatically executed by the system otherwise" and don't fit into any other category.

Among them:

  • reboot
  • poweroff
  • ping
  • traceroute
  • mtr
  • force netns (Execute shell in given Network Namespace)
  • force vrf (Execute shell in given VRF)
  • force owping
  • force twping
  • monitor bandwidth-test (iperf)
  • telnet
  • wake-on-lan

Of those, reboot, poweroff, and ping may be common enough to warrant their own top-level words.

traceroute may be common enough as well.

The top level mtr word seems entirely redundant since it's a duplicate of monitor traceroute.

The rest seem like perfect candidates for relocation to the new dedicated command family that @natali-rs1985 added recently: execute.

Quick proposal, up for debates:

  • reboot — keep.
  • poweroff — keep.
  • ping — keep.
  • traceroute — tentatively, keep.
  • mtr — delete as a duplicate of monitor traceroute.
  • force netns — move to execute shell netns.
  • force vrf — move to execute shell vrf.
  • force owping — move to execute owping.
  • force twping — move to execute twping.
  • monitor bandwidth-test — move to "execute bandwidth-test`.
  • telnet — move to execute telnet.
  • wake-on-lan — move to execute wake-on-lan.

Details

Version
-
Is it a breaking change?
Behavior change

Event Timeline

dmbaturin triaged this task as Normal priority.
natali-rs1985 changed the task status from Open to In progress.Sep 10 2024, 10:59 AM

Here are my €0.05:

reboot — system reboot.
poweroff — system poweroff.
ping — tool ping.
traceroute — tool traceroute.
mtr — tool mtr.
force netns — shell netns <cmd>. alt: exec netns <cmd>.
force vrf — shell vrf <cmd>. alt: exec vrf <cmd>.
force owping — tool owping.
force twping — tool twping.
monitor bandwidth-test — tool bandwidth-test.
telnet — telnet.
wake-on-lan — system wake-on-lan.

added:

ssh - ssh.
bash - bash.