Page MenuHomeVyOS Platform
Create Task
Maniphest T6482

LLDP shows description instead of remote port
Open, LowPublicBUG
Actions

Description

If the remote site has a description on the interface, the lldp shows the description as remote port
Local router config:

set service lldp interface eth0

Remote config:

set interfaces ethernet eth0 address '192.168.122.14/24'
set interfaces ethernet eth0 description 'UPLINK'
set service lldp interface eth0

Check op-mode, expected remote port eth0

vyos@r16:~$ show lldp neighbors 
Capability Codes: R - Router, B - Bridge, W - Wlan r - Repeater, S - Station
                  D - Docsis, T - Telephone, O - Other

Device    Local Port    Protocol    Capability    Platform                       Remote Port
--------  ------------  ----------  ------------  -----------------------------  -------------
r4        eth0          LLDP        BR            VyOS 1.5-rolling-202406130020  UPLINK
vyos@r16:~$

Expected:

vyos@r16:~$ show lldp neighbors 
Capability Codes: R - Router, B - Bridge, W - Wlan r - Repeater, S - Station
                  D - Docsis, T - Telephone, O - Other

Device    Local Port    Protocol    Capability    Platform                       Remote Port
--------  ------------  ----------  ------------  -----------------------------  -------------
r4        eth0          LLDP        BR            VyOS 1.5-rolling-202406130020  eth0
vyos@r16:~$

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.5-rolling-202406130020
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Related Objects

Event Timeline

Viacheslav created this task.Jun 13 2024, 10:28 AM
Viacheslav triaged this task as Low priority.
talmakion subscribed.Jun 13 2024, 10:45 AM

I think this one would be fixed by my PR for https://vyos.dev/T6045

pasik subscribed.Jun 13 2024, 11:02 AM
Viacheslav renamed this task from LLDP shows description instread of remote port to LLDP shows description instead of remote port.Jun 13 2024, 12:08 PM
talmakion added a comment.Jun 20 2024, 12:29 PM

Just some quick testing with 2 VyOS instances connected via 2 straight ethernet into a virtual switch. eth0 on the remote has been given a description of "ETHZERO".

Un-renamed port (in detail view):

Port:        
  PortID:       mac bc:24:11:f3:ab:a8
  PortDescr:    eth1

The summary view will use portDescr because the portID isn't an ifname.

Renamed port:

Port:        
  PortID:       ifname eth0
  PortDescr:    ETHZERO

The summary view will use portID because it has the right type (part of the PR for T6045).

$ show lldp neighbors 
Capability Codes: R - Router, B - Bridge, W - Wlan r - Repeater, S - Station
                  D - Docsis, T - Telephone, O - Other

Device           Local Port    Protocol    Capability    Platform                       Remote Port
---------------  ------------  ----------  ------------  -----------------------------  -------------
TEST-VYOS-LEFT   eth0          LLDP        R             VyOS 1.5-rolling-202406200020  eth1
TEST-VYOS-LEFT   eth0          LLDP        R             VyOS 1.5-rolling-202406200020  eth0

There might be other devices which send iffy LLDP but we'd need specific samples and logic to fix those up, VyOS->VyOS should be sorted in rolling. The included lldpd looks to be intelligently selecting what to advertise already and the PR checks portID first before moving on to portDescr.