Page MenuHomeVyOS Platform

Require command definition nodes that have an owner to also have a priority
Closed, ResolvedPublicFEATURE REQUEST

Description

The order of how owners of XML nodes are executed feels more or less like a mystery, and can lead to unexpected results:

Latest examples are:

As discussed during the maintainer meeting we should make the XML <priority> node mandatory if the parent node has an owner.

Example

Invalid

<node name="dynamic" owner="${vyos_conf_scripts_dir}/dns_dynamic.py">
  <properties>
    <help>Dynamic DNS</help>
  </properties>
  <children>
  ...
  </children>
</node>

Valid

<node name="dynamic" owner="${vyos_conf_scripts_dir}/dns_dynamic.py">
  <properties>
    <help>Dynamic DNS</help>
    <priority>990</priority>
  </properties>
  <children>
  ...
  </children>
</node>

Details

Version
-
Is it a breaking change?
Stricter validation

Event Timeline

c-po updated the task description. (Show Details)
natali-rs1985 changed the task status from Open to In progress.May 31 2024, 11:11 AM
natali-rs1985 claimed this task.
Viacheslav triaged this task as Wishlist priority.Jun 1 2024, 1:03 PM
c-po added a project: VyOS 1.5 Circinus.
c-po moved this task from Backlog to In Progress on the VyOS 1.4 Sagitta (1.4.1) board.
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta (1.4.1) board.
dmbaturin renamed this task from XML: enforce priority on nodes having an owner to Require command definition nodes that have an owner to also have a priority.Jul 1 2024, 2:30 PM
dmbaturin removed a project: VyOS 1.5 Circinus.