Page MenuHomeVyOS Platform
Create Task
Maniphest T6409

Remove unused parameter node from reverse-proxy backend
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

There is an unused backend parameters http-check configuration node in reverse-proxy backends.
HTTP health-checks are available via separate backend http-check node implemented in T6246.

We should remove redundant node, it has no effect on rendered haproxy.cfg configuration file so is pointless.

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Feature/functionality removal

Related Objects

Event Timeline

Embezzle created this task.May 27 2024, 4:52 PM
Embezzle changed the task status from Open to In progress.
Embezzle claimed this task.
Embezzle changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
syncer triaged this task as Normal priority.May 27 2024, 6:43 PM
Embezzle added a comment.May 27 2024, 6:45 PM

PR: https://github.com/vyos/vyos-1x/pull/3531

pasik subscribed.May 27 2024, 8:07 PM
Viacheslav mentioned this in T6418: reverse-proxy: backend http-check CLI option not honored.May 30 2024, 5:56 AM
Embezzle changed the task status from In progress to Needs testing.May 30 2024, 6:03 PM
Embezzle closed this task as Resolved.May 31 2024, 5:00 PM

Tested as working in: VyOS 1.5-rolling-202405310019

Viacheslav added a project: VyOS 1.4 Sagitta (1.4.0-GA).Jun 1 2024, 11:21 AM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-GA) board.