Page MenuHomeVyOS Platform

Correct the syntax of config.boot.default [..., 'ntp', 'server'] from leaf node with value to tag node
Closed, ResolvedPublicBUG

Description

The syntax of the path ... ntp server in config.boot.default is in the form of a leaf node with value instead of a tag node, even though it has always been a tag node as defined in XML.
This is normalized after load/save, and thus has gone unnoticed, but is not normalized by migration alone, which may lead to confusion or error if post-processing (say with cloud-init tools).
Make the change:

--- a/data/live-build-config/includes.chroot/opt/vyatta/etc/config.boot.default
+++ b/data/live-build-config/includes.chroot/opt/vyatta/etc/config.boot.default
@@ -29,9 +29,12 @@ system {
             address fe80::/10
             address fc00::/7
         }
-        server "time1.vyos.net"
-        server "time2.vyos.net"
-        server "time3.vyos.net"
+        server time1.vyos.net {
+        }
+        server time2.vyos.net {
+        }
+        server time3.vyos.net {
+        }
     }
     console {
         device ttyS0 {

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-GA) board.
jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.