Page MenuHomeVyOS Platform
Create Task
Maniphest T6354

Get rid of the custom boot type check in version.py
Closed, ResolvedPublic
Actions

Description

Right now, in python/vyos/version.py we have a custom check for boot type that uses the SquashFS file name (filesystem.squshafs or a version file like 1.3.7.squashfs.

But we already have a utility function for boot type checking: https://github.com/vyos/vyos-1x/blob/current/python/vyos/system/image.py#L251 and we could use it there.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

dmbaturin created this task.May 16 2024, 2:43 PM
pasik subscribed.May 16 2024, 3:04 PM
HollyGurza added a comment.May 17 2024, 9:31 AM

https://github.com/vyos/vyos-1x/pull/3474

Restricted Repository Identity mentioned this in rVYOSONEXd1b6b40891d8: Merge pull request #3474 from HollyGurza/T6354.May 17 2024, 1:36 PM
Restricted Repository Identity mentioned this in rVYOSONEX783edc98f82f: T6354: Get rid of the custom boot type check in version.py.May 17 2024, 1:36 PM
Restricted Repository Identity mentioned this in rVYOSONEXa901ad58c2bf: T6354: Get rid of the custom boot type check in version.py.May 17 2024, 1:37 PM
Restricted Repository Identity mentioned this in rVYOSONEX9f8be3255e76: Merge pull request #3477 from vyos/mergify/bp/sagitta/pr-3474.May 17 2024, 3:24 PM
Restricted Repository Identity mentioned this in rVYOSONEX4686ab7000d9: Merge pull request #3480 from jestabro/fix-circular.May 18 2024, 9:54 AM
jestabro mentioned this in rVYOSONEXe0105ef380f1: T6354: do an explicit read from version file to avoid circular reference.May 18 2024, 9:54 AM
Restricted Repository Identity mentioned this in rVYOSONEX31d3177019a5: T6354: do an explicit read from version file to avoid circular reference.May 18 2024, 9:55 AM
Restricted Repository Identity mentioned this in rVYOSONEXef31f70256a2: Merge pull request #3481 from vyos/mergify/bp/sagitta/pr-3480.May 18 2024, 12:28 PM
HollyGurza closed this task as Resolved.Jun 7 2024, 1:46 PM
HollyGurza moved this task from Open to Finished on the VyOS 1.5 Circinus board.