Page MenuHomeVyOS Platform
Create Task
Maniphest T626

Add tests for vyos-1x
Closed, ResolvedPublic
Actions

Details

Version
1.2.0

Related Objects

Event Timeline

higebu created this task.May 8 2018, 2:58 PM
higebu created this object in space S1 VyOS Public.
higebu created this object with visibility "Public (No Login Required)".
syncer subscribed.May 8 2018, 3:01 PM

We have this one
https://sonarcloud.io/dashboard?id=vyos%3Avyos-1x

higebu added a comment.May 8 2018, 3:21 PM

@syncer Yes, but we have no test code.

syncer added a comment.May 8 2018, 3:30 PM

@higebu i mean we have that one, not as replacement
but also

higebu added a comment.May 8 2018, 3:31 PM

https://docs.sonarqube.org/display/PLUG/Python+Unit+Tests+Execution+Reports+Import
https://docs.sonarqube.org/display/PLUG/Python+Coverage+Results+Import

higebu mentioned this in rVYOSONEX6f4516ea3b31: T626 Add tests for vyos-update-crontab.May 8 2018, 3:40 PM
higebu added a comment.May 9 2018, 1:06 AM

@syncer Can you add me to vyos org on sonarcloud? I'd like to setup unit tests and coverage integration.

syncer added a comment.May 9 2018, 1:07 AM

done

higebu added a comment.May 9 2018, 1:51 AM

Thanks!

higebu mentioned this in rVYOSONEX134dca87c4b8: T626 Add tests for cron.May 9 2018, 1:52 AM
higebu mentioned this in rVYOSONEX95760f30c268: T626 Add tests for cron.May 9 2018, 1:55 AM
higebu mentioned this in rVYOSONEXb7d977fa6821: T626 Add tests for cron.May 9 2018, 7:19 AM
higebu mentioned this in rVYOSONEX5ae24d275e86: T626 Add tests for cron.May 9 2018, 3:13 PM
higebu added a comment.May 10 2018, 1:52 AM

https://docs.travis-ci.com/user/sonarcloud/

higebu added a comment.May 10 2018, 1:54 AM

https://sonarcloud.io/dashboard?id=vyos%3Avyos-1x

syncer added a comment.May 10 2018, 2:02 AM

I think it looks great as for beginning
hopefully we can leverage this really soon
Thanks!

higebu added a comment.May 10 2018, 4:27 AM

@syncer The result on sonarcloud was generated by running sonar-scanner on my local PC. The step for automated measuring coverage or other metrics is following:

  1. Merge the PR I opened: https://github.com/vyos/vyos-1x/pull/10
  2. Setup automated running sonar-scanner by travis-ci or Jenkins
    • It seems that travis-ci is easier than Jenkins

I hope the test code will be a reference for contributors.

higebu mentioned this in rVYOSONEX2f6665071ece: T626 Add tests for vyos-update-crontab and initial setup for sonarcloud.May 15 2018, 1:51 PM
higebu mentioned this in rVYOSONEXfe8d03efd30c: T626 Add tests for vyos-update-crontab and initial setup for sonarcloud.May 15 2018, 1:58 PM
higebu mentioned this in rVYOSONEXbe307723d77c: T626 Add tests for vyos-update-crontab and initial setup for sonarcloud.May 15 2018, 2:30 PM
higebu mentioned this in rVYOSONEXdeef3a85555f: T626 Add tests for vyos-update-crontab and initial setup for sonarcloud.May 16 2018, 1:52 AM
dmbaturin mentioned this in rVYOSONEX99ebcdfee74d: Merge pull request #10 from higebu/add-tests.May 16 2018, 4:55 AM
higebu added a comment.May 17 2018, 6:56 AM

Jenkins build setup for sonarcloud is done on https://ci.vyos.net/view/all/job/vyos-1x/ and https://ci.vyos.net/view/all/job/vyos-1x-pr/.

syncer closed this task as Resolved.May 27 2018, 9:44 AM
syncer claimed this task.
syncer triaged this task as Normal priority.
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc1) board.
dmbaturin mentioned this in rVYOSONEX192f06025f00: Merge pull request #10 from higebu/add-tests.Jun 19 2018, 8:38 PM
higebu mentioned this in rVYOSONEX16107203972e: T626 Add tests for vyos-update-crontab and initial setup for sonarcloud.Jun 19 2018, 8:38 PM
syncer added a project: VyOS-1.2.0-GA.Jan 25 2019, 2:38 PM