Page MenuHomeVyOS Platform
Create Task
Maniphest T6058

Commit-Archive Save doesn't use https_proxy
Open, NormalPublicBUG
Actions

Description

Hey,

we tried to use the git+https commit-archive backend, but were unable to use it as we need to use a proxy for outside communication.
The reason for this is that the git subprocess is being called without the https_proxy environment variable that we set in the vyos config.

I found the lines where the environment for git were defined and when I added the correct environment var the commits were able to be saved in git.
https://github.com/vyos/vyos-1x/blob/72e597d5c258b1730d59d9f8cd08331338cee5b5/python/vyos/remote.py#L361-L367

Thanks!

Best regards,
modzilla

Details

Version
ep1
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

modzilla99 created this task.Feb 23 2024, 12:49 PM
Viacheslav triaged this task as Normal priority.Feb 23 2024, 12:59 PM
Viacheslav edited projects, added VyOS 1.4 Sagitta (1.4.0-epa1), VyOS 1.5 Circinus; removed VyOS 1.4 Sagitta.
Viacheslav changed the task status from Open to Needs reporter action.Apr 23 2024, 5:09 PM
Viacheslav subscribed.

@modzilla99 Could you provide an example of set commands to reproduce?

pasik subscribed.Apr 23 2024, 6:27 PM
syncer edited projects, added VyOS 1.4 Sagitta (1.4.0-GA); removed VyOS 1.4 Sagitta (1.4.0-epa1).May 15 2024, 9:30 AM
modzilla99 added a comment.May 16 2024, 7:42 AM

Hey,

sorry for the late reply.You don't need any special commands. The only thing you have to set is the proxy and the commit archive.

set system config-management commit-archive location 'git+https://vyos:abc@git.myorg.com/infrastructure/vyos-configuration'
set system proxy port '8888'
set system proxy url 'http://10.7.2.100'

Best regards,
Justin Lamp

Viacheslav changed the task status from Needs reporter action to Open.May 16 2024, 7:55 AM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.1); removed VyOS 1.4 Sagitta (1.4.0-GA), VyOS 1.5 Circinus.Jul 2 2024, 7:29 PM
dmbaturin added a project: Bugs.Sep 15 2024, 5:03 PM
syncer edited projects, added VyOS Rolling; removed VyOS 1.4 Sagitta (1.4.1).Nov 1 2024, 3:27 PM
syncer moved this task from Need Triage to Backlog - Bug on the VyOS Rolling board.
syncer added a subscriber: Global Notifications.Nov 1 2024, 9:19 PM
HollyGurza subscribed.EditedFeb 5 2025, 4:58 AM

looks like the problem was fixed in this task: T7048

https://github.com/vyos/vyos-1x/pull/4303

System-wide proxy config will implemented here https://vyos.dev/T1741 and still work correctly for all new sessions

HollyGurza added a comment.Feb 5 2025, 5:45 AM

fix for another git commit archive related problem:
https://github.com/vyos/vyos-1x/pull/4333

Restricted Repository Identity mentioned this in rVYOSONEXe47feb25a640: T6058: Fix popen command wrapper handling.Feb 7 2025, 5:53 PM
Restricted Repository Identity mentioned this in rVYOSONEX5463cf3c3c96: Merge pull request #4333 from HollyGurza/T6058.Feb 7 2025, 5:53 PM