Page MenuHomeVyOS Platform
Create Task
Maniphest T6041

image-tools: install fails from PXE boot into live iso due to restrictive logic
Closed, ResolvedPublicBUG
Actions

Description

Attempting to install image from a PXE boot into the live image fails with:

vyos@vyos:~$ install image
The system is already installed. Please use "add system image" instead.

Report and details provided in forum posting:
https://forum.vyos.io/t/cannot-install-vyos-after-booting-into-live-with-pxe/13704/1

Upon inspection, it would seem clear that the logic is too restrictive, as the error message is returned on detecting that the boot cmdline does not indicate a 'live' boot:
https://github.com/vyos/vyos-1x/blob/current/src/op_mode/image_installer.py#L639-L640
https://github.com/vyos/vyos-1x/blob/current/python/vyos/system/image.py#L251

This will need to be verified, the logic extended, and viability of PXE boot confirmed.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

jestabro created this task.Feb 15 2024, 1:02 AM
jestabro triaged this task as High priority.
jestabro created this object in space S1 VyOS Public.
jestabro renamed this task from image-tools: install fails from PXE boot into live iso for obvious reason to image-tools: install fails from PXE boot into live iso due to restrictive logic.Feb 15 2024, 1:07 AM
pasik subscribed.Feb 15 2024, 10:18 AM
jestabro added projects: VyOS 1.5 Circinus, VyOS 1.4 Sagitta.Feb 15 2024, 2:04 PM
jestabro added a project: Restricted Project.Feb 15 2024, 3:14 PM
I-n-d-y subscribed.Feb 15 2024, 7:28 PM
jestabro added a comment.Feb 16 2024, 8:16 PM

Simple fix here; PR pending following tests.
https://github.com/jestabro/vyos-1x/tree/pxe-boot

jestabro added a comment.Feb 17 2024, 6:57 PM

PR:
https://github.com/vyos/vyos-1x/pull/3024

Restricted Repository Identity mentioned this in rVYOSONEX2a6318dfc1c3: Merge pull request #3024 from jestabro/pxe-boot.Feb 17 2024, 8:13 PM
jestabro mentioned this in rVYOSONEX5949ff72a9f9: image-tools: T6041: fix logic of is_live_boot to allow for PXE boot.Feb 17 2024, 8:13 PM
Restricted Repository Identity mentioned this in rVYOSONEX64e8ae09386f: image-tools: T6041: fix logic of is_live_boot to allow for PXE boot.Feb 17 2024, 8:14 PM
Restricted Repository Identity mentioned this in rVYOSONEX85e3866dde34: Merge pull request #3025 from vyos/mergify/bp/sagitta/pr-3024.Feb 17 2024, 9:12 PM
jestabro closed this task as Resolved.Feb 18 2024, 4:13 PM
jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus board.

Forum user reports that this is resolved.

jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Feb 18 2024, 4:13 PM