I finally updated to vyos-1.4.0-rc1 and i noticed to some of my initial code for better error reporting has been removed for commit-archive.
Now the output of commit archive is funky if you have multiple commit-archive locations defined. Also the errors are now all over the place, which used to be neatly formatted.
Example in vyos 1.4.0-rc1, notice that the second commit archive location is printed directly after the first, and the error for the second location is all of the place:
vyos@vyos# show system config-management commit-archive location location git+ssh://[email protected]/yun/vyos-configs.git location git+ssh://[email protected]/yun/vyos-empty.git [edit] vyos@vyos# vyos@vyos# commit Archiving config... git+ssh://gitea.local/yun/vyos-configs.git git+ssh://gitea.local/yun/vyos-empty.git Unable to upload "git+ssh://[email protected]/yun/vyos-empty.git/config.boot-vyos.20240103_230031": Cloning into '/tmp/git-commit-archive-y1bxi5pc/repository'... Gitea: Public (Deploy) Key: 11:vyos-1.4.0-rc1 is not authorized to read yun/vyos-empty. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. [edit] vyos@vyos#
Before the removal, it would be neatly formatted, and also notice the OK and FAILED after each location and nicely formatted error:
Archiving config... git+ssh://gitea.local/yun/vyos-configs.git OK git+ssh://gitea.local/yun/vyos-empty.git FAILED > Unable to upload "git+ssh://[email protected]/yun/vyos-empty.git/config.boot-vyos.20240103_230031": Cloning into '/tmp/git-commit-archive-y1bxi5pc/repository'... > Gitea: Public (Deploy) Key: 11:vyos-1.4.0-rc1 is not authorized to read yun/vyos-empty. > fatal: Could not read from remote repository. > Please make sure you have the correct access rights > and the repository exists.
Should I add back this behaviour with a PR. Or at least fix the OK and FAILED and just show no error at all?