Maniphest T5880

verify_source_interface should not allow dynamic interfaces like ppp, l2tp, ipoe or sstpc client interfaces
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Dec 31 2023, 9:46 AM

Tags

Referenced Files

None

Subscribers

Description

It makes no sense to source e.g. a tunnel interface from a dynamic interface that is used for client connections - if such a setup is needed one should use dynamic routing and a dummy source interface

Details

Version: 1.4.0-rc1
Is it a breaking change?: Stricter validation
Issue type: Bug (incorrect behavior)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG	c-po	T5879 tunnel: sourceing from dynamic pppoe0 interface will fail on reboots
		Resolved	BUG	c-po	T5880 verify_source_interface should not allow dynamic interfaces like ppp, l2tp, ipoe or sstpc client interfaces

Event Timeline

c-po created this task.Dec 31 2023, 9:46 AM

c-po claimed this task.

PR https://github.com/vyos/vyos-1x/pull/2728

pasik subscribed.Dec 31 2023, 1:09 PM

Restricted Repository Identity mentioned this in rVYOSONEX4519506c6f53: Merge pull request #2728 from c-po/verify-T5880.Jan 1 2024, 10:21 AM

c-po mentioned this in rVYOSONEX5062f5d31354: configverify: T5880: raise exception if interfaces sourced form dynamic….Jan 1 2024, 10:21 AM

Restricted Repository Identity mentioned this in rVYOSONEX069e4873ee6e: configverify: T5880: raise exception if interfaces sourced form dynamic….Jan 1 2024, 11:44 AM

PR for 1.4 sagitta https://github.com/vyos/vyos-1x/pull/2732

Restricted Repository Identity mentioned this in rVYOSONEX48f2a0a8d2fe: Merge pull request #2732 from vyos/mergify/bp/sagitta/pr-2728.Jan 3 2024, 10:51 AM

c-po changed the task status from Open to In progress.Jan 3 2024, 4:16 PM

c-po closed this task as Resolved.