Page MenuHomeVyOS Platform

error on dhcpv6-server range prefix with trailing colon (:)
Open, NormalPublicBUG

Description

When specifying a range prefix withing a subnet in the dhcpv6-server config section, if the range is of the invalid shape:

2001:aaa:bbb::ccc:/xxx

the VyOS configurator will accept the value but dhcpdv6 won't start and will error out on the range6 line.

This can be fixed by specifying the address as follows (i.e. by adding a trailing 0):

2001:aaa:bbb::ccc:0/xxx

VyOS should detect the invalid IPv6 address and reject it before committing.

Details

Difficulty level
Unknown (require assessment)
Version
1.4-rolling-202311081035
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav triaged this task as Normal priority.Jan 20 2024, 2:01 PM

Question as I don’t know the projects’ history: the Python ipaddress library seems to offer the features of ipaddrcheck plus some additional nice to haves. Is a migration from ipaddrcheck to ipaddress being considered?

https://docs.python.org/3/library/ipaddress.html

@Giggum The main reason for using ipaddrcheck is its speed (it's a compiled binary). Python is way too slow for validators due to the interpreter startup cost, so it's not an option until we completely overhaul the CLI backend. I'll look into the issue.