Page MenuHomeVyOS Platform
Create Task
Maniphest T5555

Fix timezone migrator (system 13-to-14)
Closed, ResolvedPublicBUG
Actions

Description

The migration script system 13-to-14 executes find /usr/share/zoneinfo/posix -type f -or -type l | sed -e s:/usr/share/zoneinfo/posix/:: to find a list of valid timezones. This command only returns the first level of the timezones (continent etc.) resulting in the migrator changing valid timezones to UTC.

We should update the migrator to use systemd-provided command timedatectl list-timezones to get a valid list and prevent valid timezones being mistakenly changed.

Details

Difficulty level
Easy (less than an hour)
Version
1.3 and up
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

sarthurdev changed the task status from Open to In progress.Sep 7 2023, 12:29 PM
sarthurdev claimed this task.
sarthurdev created this task.
sarthurdev changed the task status from In progress to Needs testing.Sep 7 2023, 12:54 PM

current PR: https://github.com/vyos/vyos-1x/pull/2217
1.4 PR: https://github.com/vyos/vyos-1x/pull/2218
1.3 PR: https://github.com/vyos/vyos-1x/pull/2219

sarthurdev moved this task from Need Triage to In Progress on the VyOS 1.4 Sagitta board.Sep 7 2023, 1:13 PM
sarthurdev moved this task from Need Triage to In Progress on the VyOS 1.5 Circinus board.
sarthurdev moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus (1.3.5) board.
pasik added a subscriber: pasik.Sep 7 2023, 2:58 PM
Viacheslav edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.5).Sep 7 2023, 3:13 PM
sarthurdev mentioned this in T5558: Update config test to check resulting migrations.Sep 7 2023, 5:53 PM
c-po closed this task as Resolved.Sep 10 2023, 2:16 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.4) board.
dmbaturin mentioned this in 1.3.4.Sep 14 2023, 1:07 PM
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.Dec 25 2023, 7:46 AM