Page MenuHomeVyOS Platform
Create Task
Maniphest T5518

Add MLD protocol support
Closed, ResolvedPublic
Actions

Description

Currently VyOS has protocol igmp option to enable IGMP querier and reports through FRR's pimd.

I would like to add protocol mld for IPv6 as well since FRR's IPv6 multicast functionality has significantly improved.

Enabling MLD querier and reports on a VyOS router will allow us to turn on MLD snooping on layer-3 switches.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Feature (new functionality)

Related Objects

Event Timeline

vfreex created this task.Aug 27 2023, 11:54 PM
vfreex created this object in space S1 VyOS Public.
vfreex added a comment.Aug 28 2023, 12:05 AM

https://github.com/vyos/vyos-1x/pull/2179

vfreex changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.Aug 28 2023, 12:12 AM
vfreex changed Issue type from Unspecified (please specify) to Feature (new functionality).
Viacheslav changed the task status from Open to In progress.Aug 31 2023, 1:47 PM
Viacheslav assigned this task to vfreex.
Apachez added a subscriber: Apachez.Sep 10 2023, 5:17 AM

Something is broken in smoketest test_protocols_pim6.py:

https://github.com/vyos/vyos-rolling-nightly-builds/actions/runs/6133954453/job/16646294279

See "Run smoketests" line 28676 and forward.

vfreex added a comment.Sep 10 2023, 5:27 AM
In T5518#159341, @Apachez wrote:

Something is broken in smoketest test_protocols_pim6.py:

https://github.com/vyos/vyos-rolling-nightly-builds/actions/runs/6133954453/job/16646294279

See "Run smoketests" line 28676 and forward.

I will have a look.

vfreex added a comment.Sep 10 2023, 5:37 AM

https://github.com/vyos/vyos-1x/pull/2233 to fix the smoketest.

Apachez mentioned this in T5562: Smoketests fail for vyos:current (test_netns.py).Sep 10 2023, 6:13 AM
pasik added a subscriber: pasik.Sep 10 2023, 8:47 AM
Apachez added a comment.Sep 10 2023, 10:03 PM

I dont know if its related to this task but I noticed recently that even if I have no IPv6 configured on any interface and have IPv6 disabled for forwarding:

set system ipv6 disable-forwarding

I can in VyOS 1.5-rolling-202309080021 see an additional pim6reg interface!?

vyos@vyos:~$ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
...
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq master MGMT state UP group default qlen 1000
...
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq master INTERNET state UP group default qlen 1000
...
4: eth2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq master INTERNET state UP group default qlen 1000
...
5: eth3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq master INTERNET state UP group default qlen 1000
...
6: pim6reg@NONE: <NOARP,UP,LOWER_UP> mtu 1452 qdisc noqueue state UNKNOWN group default qlen 1000
    link/pimreg 
7: INTERNET: <NOARP,MASTER,UP,LOWER_UP> mtu 65575 qdisc noqueue state UP group default qlen 1000
...
8: MGMT: <NOARP,MASTER,UP,LOWER_UP> mtu 65575 qdisc noqueue state UP group default qlen 1000
...

Its also visible when running:

monitor bandwidth interface *
vfreex added a comment.Sep 11 2023, 9:10 AM

pim6reg is created by FFR's pim6d. It seems to me that it will create such as interface for each VRF. Does this interface have any functional impact on your setup?

Apachez added a comment.Sep 11 2023, 9:21 AM

Im a bit allergic to have stuff automatically created which clearly is not enabled by the config.

Since I have no multicast settings configured no interfaces related to multicast should be autocreated.

Viacheslav changed the task status from In progress to Needs testing.Sep 11 2023, 9:48 AM
Viacheslav closed this task as Resolved.Sep 23 2023, 2:21 PM
Viacheslav added a subscriber: Viacheslav.Sep 29 2023, 4:21 PM

Could be a cause of this bug https://forum.vyos.io/t/igmp-proxy-not-working-in-1-4-since-around-7-sept

vfreex added a comment.Sep 30 2023, 9:04 AM

@Viacheslav This doesn't seem to be related. This PR is merged to 1.5 instead of 1.4.