Page MenuHomeVyOS Platform

Schema generation from op-mode functions should set default 'false' on boolean arguments
Closed, ResolvedPublicBUG

Description

We should review the question of type hint Optional for boolean-valued options. Type hint bool is interpreted as default false in the command line, whether or not it is wrapped in Optional; type hint 'bool' is interpreted as nullable in schema generation only if wrapped in Optional. Schema generation should match the behavior of the command line interpretation.

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

jestabro triaged this task as Normal priority.Dec 19 2022, 8:03 PM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro changed Difficulty level from Easy (less than an hour) to Normal (likely a few hours).
jestabro changed Difficulty level from Normal (likely a few hours) to Easy (less than an hour).

Fix pushed for schema generation.

jestabro updated the task description. (Show Details)
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.