Page MenuHomeVyOS Platform
Create Task
Maniphest T4726

Add completion and validation for the accel-ppp RADIUS vendor option
Closed, ResolvedPublic
Actions

Description

Right now if one wants to use the authentication radius rate-limit vendor option in L2TP and other accel-ppp services, they need to look up dictionary files in /usr/share/accel-ppp/radius and correctly guess which ones contain attributes useful for rate limiting.

Instead, we could provide completion for its built-in dictionaries (alcatel, cisco, microsoft, mikrotik) and add a validator to ensure that specified file exists, so that people can still use custom dictionaries if they want to.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

dmbaturin created this task.Oct 3 2022, 4:15 PM
dmbaturin added projects: VyOS 1.4 Sagitta, VyOS 1.3 Equuleus (1.3.3).Oct 3 2022, 4:27 PM
dmbaturin changed Issue type from Improvement (missing useful functionality) to Bug (incorrect behavior).
pasik added a subscriber: pasik.Oct 3 2022, 5:58 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:38 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
Viacheslav changed the task status from Open to Needs testing.Aug 30 2023, 2:00 PM
Viacheslav added a subscriber: Viacheslav.EditedNov 1 2023, 7:45 PM

There is a bug when we use lowercase "cisco"

set service pppoe-server authentication radius rate-limit vendor 'cisco'

It doesn't work as vendor is Cisco not cisco

vyos@vyos-lns# sudo cat  /usr/share/accel-ppp/radius/dictionary.cisco | grep -i vendor
VENDOR		Cisco

On the FreeRADIUS site dictionary also have vendor=Cisco

/ # cat /usr/share/freeradius/dictionary.cisco | grep -i vendor
VENDOR		Cisco				9

It's cause that attribute doesn't work at all.
We should remove validators.

Viacheslav removed a project: VyOS 1.3 Equuleus (1.3.5).Nov 1 2023, 7:59 PM
Viacheslav added a project: VyOS 1.5 Circinus.
Viacheslav added a comment.Nov 1 2023, 8:51 PM

PR https://github.com/vyos/vyos-1x/pull/2423

Viacheslav closed this task as Resolved.Jan 20 2024, 11:05 AM