Page MenuHomeVyOS Platform
Create Task
Maniphest T458

Disabling the in-memory table plugin has no effect
Closed, ResolvedPublicBUG
Actions

Description

When adding the "set system flow-accounting disable-imt" statement to the flow accounting configuration, the IMT plugin is still configured. It appears that the 'disable-imt' portion of the configuration tree is not getting defined. To check this, I added "print $config->returnValue('disable-imt');" below line 289 of the /opt/vyatta/sbin/vyatta-netflow.pl script and the removed and readded my flow accounting configuration. I received an error on the cli saying "Use of uninitialized value in print at /opt/vyatta/sbin/vyatta-netflow.pl line 290."

Details

Version
1.1.8

Event Timeline

cohn created this task.Nov 14 2017, 5:24 PM
syncer triaged this task as Low priority.Dec 21 2017, 9:17 PM
syncer edited projects, added VyOS 1.1.x (1.1.9), VyOS 1.2 Crux; removed VyOS 1.1.x (1.1.8).
pasik subscribed.Dec 26 2017, 10:41 PM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc3); removed VyOS 1.2 Crux, VyOS 1.1.x (1.1.9).Oct 13 2018, 9:22 AM
syncer subscribed.

please retest on latest rolling

syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc4); removed VyOS 1.2 Crux (VyOS 1.2.0-rc3).Oct 15 2018, 10:15 PM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc5); removed VyOS 1.2 Crux (VyOS 1.2.0-rc4).Oct 24 2018, 4:39 PM
cohn added a comment.Oct 27 2018, 11:57 PM

Tested on the latest 1.2.0-rc4 and it appears that the memory plugin is still enabled.

I'm using the following configuration:

set system flow-accounting disable-imt
set system flow-accounting interface 'eth0'
set system flow-accounting netflow sampling-rate '1'
set system flow-accounting netflow server x.x.x.x port '2556'
set system flow-accounting netflow version '9'
set system flow-accounting syslog-facility 'daemon'

I see the following in my process list:

root@vyos:~# ps auxwww | grep uacct
root      8783  0.0  2.8 115508 29528 ?        Ss   23:38   0:00 uacctd: Core Process [default]
root      8785  0.0  1.4 109820 15000 ?        S    23:38   0:00 uacctd: IMT Plugin [default_memory]
root      8786  0.0  0.5 100572  6100 ?        S    23:38   0:00 uacctd: Netflow Probe Plugin [default_nfprobe]

And the following plugins are enabled in my uacctd configuration:

root@vyos:~# grep plugins /etc/pmacct/uacctd.conf
plugins: memory,nfprobe
syncer assigned this task to hagbard.Oct 28 2018, 8:46 AM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc6); removed VyOS 1.2 Crux (VyOS 1.2.0-rc5).Oct 29 2018, 6:16 PM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc7); removed VyOS 1.2 Crux (VyOS 1.2.0-rc6).Nov 6 2018, 12:57 AM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc8); removed VyOS 1.2 Crux (VyOS 1.2.0-rc7).Nov 13 2018, 3:48 AM
hagbard changed the task status from Open to In progress.Nov 15 2018, 5:24 PM
hagbard added a comment.Nov 15 2018, 5:37 PM

bug confirmed in 1.2.0-rolling+201811150337.

hagbard closed this task as Resolved.Nov 15 2018, 6:28 PM

https://github.com/vyos/vyatta-netflow/commit/07abd7362b12a8a3c988d223113f6ec7c082638f

hagbard moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc8) board.Nov 15 2018, 6:31 PM
c-po subscribed.Nov 15 2018, 6:38 PM

Your commit enables memory plugin when disable is configured?

hagbard added a comment.Nov 15 2018, 6:42 PM

Ahh crap. I'll fix that right away.

hagbard added a comment.Nov 15 2018, 6:50 PM

https://github.com/vyos/vyatta-netflow/commit/3562ed47b5f897d09ba01c5d2cdc3bfbb1ee253b

syncer added a project: VyOS-1.2.0-GA.Jan 25 2019, 2:38 PM