Page MenuHomeVyOS Platform
Create Task
Maniphest T4531

NAT op-mode errors with exclude rules
Closed, ResolvedPublicBUG
Actions

Description

VyOS configuration:

set nat source rule 10 destination address '192.0.2.0/24'
set nat source rule 10 exclude
set nat source rule 10 outbound-interface 'any'
set nat source rule 10 protocol 'all'

Show:

vyos@r14# run show nat source rules 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/show_nat_rules.py", line 114, in <module>
    print(format_nat_rule.format(rule, srcdests[0], tran_addr, interface))
IndexError: list index out of range
Rule       Source                                             Translation                                        Outbound Interface
----       ------                                             -----------                                        ------------------
[edit]
vyos@r14#

Extended configuration:

set nat source rule 10 destination address '192.0.2.0/24'
set nat source rule 10 exclude
set nat source rule 10 outbound-interface 'any'
set nat source rule 10 protocol 'all'
set nat source rule 10 source address '0.0.0.0/0'
set nat source rule 100 outbound-interface 'eth0'
set nat source rule 100 source address '203.0.113.0/24'
set nat source rule 100 translation address masquerade

Show:

vyos@r14# run show nat source rules 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/show_nat_rules.py", line 114, in <module>
Rule       Source                                             Translation                                        Outbound Interface
----       ------                                             -----------                                        ------------------
    print(format_nat_rule.format(rule, srcdests[0], tran_addr, interface))
TypeError: unsupported format string passed to dict.__format__
[edit]
vyos@r14#

Details

Version
VyOS 1.4-rolling-202207111030
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFEATURE REQUESTNoneT4564 Root task for rewriting [op-mode] to vyos.opmode format
 ResolvedBUGViacheslavT4531 NAT op-mode errors with exclude rules

Event Timeline

Viacheslav created this task.Jul 14 2022, 9:38 AM
Viacheslav added a comment.Jul 23 2022, 5:28 PM

It will be fixed in T4545
PR https://github.com/vyos/vyos-1x/pull/1426

Viacheslav added a parent task: T4564: Root task for rewriting [op-mode] to vyos.opmode format.Jul 23 2022, 5:39 PM
Viacheslav changed the task status from Open to In progress.Jul 26 2022, 7:08 PM

VyOS config:

set nat source rule 10 destination address '192.0.2.0/24'
set nat source rule 10 exclude
set nat source rule 10 outbound-interface 'any'
set nat source rule 10 protocol 'all'
set nat source rule 10 source address '0.0.0.0/0'
set nat source rule 100 outbound-interface 'eth0'
set nat source rule 100 source address '203.0.113.0/24'
set nat source rule 100 translation address masquerade

The bug is still here:

vyos@r14# run show nat source rules 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/nat.py", line 157, in <module>
    res = vyos.opmode.run(sys.modules[__name__])
  File "/usr/lib/python3/dist-packages/vyos/opmode.py", line 118, in run
    res = func(**args)
  File "/usr/libexec/vyos/op_mode/nat.py", line 152, in show_rules
    return _get_formatted_output_rules(nat_rules, direction)
  File "/usr/libexec/vyos/op_mode/nat.py", line 103, in _get_formatted_output_rules
    sport {sport}'''
UnboundLocalError: local variable 'sport' referenced before assignment
[edit]
vyos@r14#
Viacheslav claimed this task.Jul 26 2022, 7:08 PM
Viacheslav added a comment.Jul 26 2022, 7:33 PM

Fix PR https://github.com/vyos/vyos-1x/pull/1439

masterit subscribed.Jul 26 2022, 7:49 PM
pasik subscribed.Jul 26 2022, 9:09 PM
Restricted Repository Identity mentioned this in rVYOSONEXb33de0bac817: Merge pull request #1439 from sever-sever/T4531.Jul 27 2022, 5:54 PM
Viacheslav mentioned this in rVYOSONEX948e55af1f59: nat: T4531: Fix op-mode NAT rules add default values.Jul 27 2022, 5:54 PM
Viacheslav changed the task status from In progress to Needs testing.Jul 27 2022, 10:02 PM
Viacheslav closed this task as Resolved.Jul 28 2022, 10:21 AM
Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.