Page MenuHomeVyOS Platform
Create Task
Maniphest T4529

Backtrace for config-archive when netwofrk is not configured
Not ApplicablePublicBUG
Actions

Description

We have to add additional check to commit-archive command to prevent backtrace when network is not configured.

vyos@vyos# run show interfaces 
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
eth0             -                                 u/u  
eth1             -                                 u/u  
eth2             -                                 u/u  
eth3             -                                 u/u  
lo               127.0.0.1/8                       u/u  
                 ::1/128                                
[edit]
vyos@vyos# set system config-management commit-archive location scp://vyos@vyos@192.168.255.11:/tmp/
[edit]
vyos@vyos# commit
Use of uninitialized value $source_address in concatenation (.) or string at /etc/commit/post-hooks.d/02vyatta-commit-push.pl line 78.
Archiving config...
  scp://192.168.255.11:/tmp/ Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 294, in upload
    urlc(urlstring, *args, **kwargs).upload(local_path)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 187, in upload
    with self._establish() as ssh, ssh.open_sftp() as sftp:
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 174, in _establish
    sock = socket.create_connection((self.hostname, self.port), socket.getdefaulttimeout(), self.source)
  File "/usr/lib/python3.7/socket.py", line 727, in create_connection
    raise err
  File "/usr/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
OSError: [Errno 101] Network is unreachable

Details

Version
1.3.0
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Unknown Object (User) created this task.Jul 13 2022, 9:42 AM
Unknown Object (User) added a comment.Jul 13 2022, 9:50 AM

The similar issue and for the 1.3.1-S1

vyos@vyos# run show version 

Version:          VyOS 1.3.1-S1
Release train:    equuleus
...

vyos@vyos#  set system config-management commit-archive location scp://test@192.168.255.11:/tmp/
[edit]
vyos@vyos# commit
Archiving config...
  scp://192.168.255.11:/tmp/ Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 293, in upload
    urlc(urlstring, *args, **kwargs).upload(local_path)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 186, in upload
    with self._establish() as ssh, ssh.open_sftp() as sftp:
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 173, in _establish
    sock = socket.create_connection((self.hostname, self.port), socket.getdefaulttimeout(), self.source)
  File "/usr/lib/python3.7/socket.py", line 727, in create_connection
    raise err
  File "/usr/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
OSError: [Errno 101] Network is unreachable
pasik subscribed.Jul 13 2022, 10:10 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.3 Equuleus.Aug 14 2022, 1:05 PM
dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.2).Aug 14 2022, 5:58 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:46 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:36 PM
dmbaturin triaged this task as Low priority.Jan 10 2024, 10:22 PM
dmbaturin edited projects, added VyOS 1.5 Circinus, VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.6).
Viacheslav closed this task as Not Applicable.Apr 26 2024, 12:46 PM
Viacheslav subscribed.

looks good for VyOS 1.5-rolling-202404260019 and VyOS 1.4-stable-202404120309

vyos@r4# set system config-management commit-archive location scp://vyos:vyos@192.168.255.11/tmp/
vyos@r4# 
[edit]
vyos@r4# commit
Archiving config...
  scp://192.168.255.11/tmp/ Unable to upload "scp://vyos:vyos@192.168.255.11/tmp//config.boot-r4.vyos.local.20240426_153518": [Errno 101] Network is unreachable
run-parts: /etc/commit/post-hooks.d/02vyos-commit-archive exited with return code 1
[edit]
vyos@r4#

1.3.6

vyos@r1# commit
Archiving config...
  scp://192.168.255.11:/tmp/ Cannot connect to "192.168.255.11:22": [Errno 101] Network is unreachable
[edit]
vyos@r1#