Page MenuHomeVyOS Platform
Create Task
Maniphest T4467

Validator Does Not Accept Signed Numbers
Closed, ResolvedPublicBUG
Actions

Description

The numeric validator does not accept signed numbers, and as a result causes errors with relative metrics in route-maps:

trae@cr01a-vyos# set policy route-map BGP-BACKBONE-OUT rule 10 set metric "+100"
      
  '+100' is not a valid number                                
      
                                                          
                                                                            
  Invalid value
  Value validation failed                                 
  Set failed                                                                                                                                                                                                                                     
[edit]

Details

Difficulty level
Easy (less than an hour)
Version
1.4-rolling-202205290217
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

trae32566 created this task.Jun 16 2022, 6:44 AM
c-po added a subscriber: c-po.Jun 16 2022, 7:06 AM

route-maps support a relative adjustment of the metric (https://github.com/vyos/vyos-1x/blob/current/interface-definitions/policy.xml.in#L1402-L1417)

The validator should support verifying also signed numbers

Signed positive not working

bash
[email protected]:~$ /usr/libexec/vyos/validators/numeric --range -10-10 +4
'+4' is not a valid number
[email protected]:~$ /usr/libexec/vyos/validators/numeric --range -10-10 -5
/usr/libexec/vyos/validators/numeric: unknown option '-5'.
Usage: /usr/libexec/vyos/validators/numeric [OPTIONS] <number>
  --non-negative Check if the number is non-negative (>= 0)
  --positive Check if the number is positive (> 0)
  --range Check if the number is within a range (inclusive)
  --float Allow floating-point numbers
  -help  Display this list of options
  --help  Display this list of options

Signed negative not working

bash
[email protected]:~$ /usr/libexec/vyos/validators/numeric --range -10-10 -- -5
/usr/libexec/vyos/validators/numeric: unknown option '--'.
Usage: /usr/libexec/vyos/validators/numeric [OPTIONS] <number>
  --non-negative Check if the number is non-negative (>= 0)
  --positive Check if the number is positive (> 0)
  --range Check if the number is within a range (inclusive)
  --float Allow floating-point numbers
  -help  Display this list of options
  --help  Display this list of options
[email protected]:~$ /usr/libexec/vyos/validators/numeric --range -10-10 -5
/usr/libexec/vyos/validators/numeric: unknown option '-5'.
Usage: /usr/libexec/vyos/validators/numeric [OPTIONS] <number>
  --non-negative Check if the number is non-negative (>= 0)
  --positive Check if the number is positive (> 0)
  --range Check if the number is within a range (inclusive)
  --float Allow floating-point numbers
  -help  Display this list of options
  --help  Display this list of options
c-po triaged this task as Normal priority.Jun 16 2022, 7:06 AM
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
pasik added a subscriber: pasik.Jun 16 2022, 3:49 PM
jestabro added a subscriber: jestabro.EditedJun 17 2022, 5:31 PM

One approach is linked below; to be discussed before PR.
https://github.com/vyos/vyos-utils/compare/master...jestabro:increment-decrement?expand=1

jestabro added a comment.Jun 18 2022, 12:55 AM

PR: https://github.com/vyos/vyos-utils/pull/4
Adding the additional validator to policy.xml.in allows the smoketest (above) to pass.

jestabro claimed this task.Jun 18 2022, 12:59 AM
c-po added a comment.Jun 18 2022, 6:04 AM

Tested and works correct. Thanks @jestabro

c-po closed this task as Resolved.Jun 18 2022, 6:04 AM