Page MenuHomeVyOS Platform
Create Task
Maniphest T4455

smp-affinity required by some platforms but doesn't exists in the CLI
Open, NormalPublicBUG
Actions

Description

SMP-affinity was dropped in T3048 commit
But in some platforms (for example XEN, XCP-NG) that cause that all IRQs bind to a single CPU core

vyos@rxen:~$ sudo cat /proc/interrupts 
            CPU0       CPU1       
...

  61:          1          0  xen-dyn-lateeoi     -event     hvc_console
  62:         33          0  xen-dyn-lateeoi     -event     vif0-q0-tx
  63:         19          0  xen-dyn-lateeoi     -event     vif0-q0-rx
  64:          9          0  xen-dyn-lateeoi     -event     vif0-q1-tx
  65:          6          0  xen-dyn-lateeoi     -event     vif0-q1-rx
  66:       3001          0  xen-dyn-lateeoi     -event     blkif
  67:         53          0  xen-dyn-lateeoi     -event     vif1-q0-tx
  68:       3528          0  xen-dyn-lateeoi     -event     vif1-q0-rx
  69:       5145          0  xen-dyn-lateeoi     -event     vif1-q1-tx
  70:       2664          0  xen-dyn-lateeoi     -event     vif1-q1-rx

To work around it download the script irq-affinity from 1.2 and execute it manually

sudo wget -O /config/scripts/irq-affinity.pl https://raw.githubusercontent.com/vyos/vyatta-cfg-system/crux/scripts/system/irq-affinity.pl
sudo perl /config/scripts/irq-affinity.pl eth0 auto

1.2 Because it contains CPU detection code for "XEN"

Maybe we should return CLI set interface ethernet ethX smp-affinity auto as an option

One question is should we use old Perl code or rewrite it to Python.

Details

Version
1.3.2
Is it a breaking change?
Perfectly compatible

Related Objects

Event Timeline

Viacheslav created this task.Jun 2 2022, 3:21 PM
pasik subscribed.Jun 2 2022, 7:24 PM
cfischer subscribed.Jun 3 2022, 8:07 AM
dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.2).Aug 14 2022, 6:49 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:46 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:36 PM
dmbaturin triaged this task as Normal priority.Jan 10 2024, 10:11 PM
dmbaturin added projects: VyOS 1.4 Sagitta, VyOS 1.5 Circinus.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.7); removed VyOS 1.3 Equuleus (1.3.6).Feb 10 2024, 9:17 AM
syncer edited projects, added VyOS 1.4 Sagitta (1.4.0-GA); removed VyOS 1.4 Sagitta.May 7 2024, 8:02 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.8); removed VyOS 1.3 Equuleus (1.3.7).May 13 2024, 7:31 PM
dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.9); removed VyOS 1.3 Equuleus (1.3.8).Jun 20 2024, 10:18 AM
dmbaturin added a project: Restricted Project.Sep 16 2024, 4:16 PM
dmbaturin edited projects, added VyOS Rolling, VyOS 1.4 Sagitta (1.4.0); removed Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.0-GA).Oct 14 2024, 9:27 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to improvement.
syncer removed projects: VyOS 1.4 Sagitta (1.4.0), VyOS 1.5 Circinus.Oct 30 2024, 1:43 PM
syncer subscribed.

@Viacheslav do we have list of such platforms

Viacheslav added a comment.Oct 30 2024, 10:02 PM

@syncer What I know only from XEN or XCP-NG was reported
Do no have reports from other platforms

syncer added a comment.Oct 30 2024, 10:06 PM

@Viacheslav, maybe we should just run the script on such platforms instead of doing CLI?

Viacheslav added a comment.EditedOct 30 2024, 10:15 PM

@syncer In my opinion, it is better to have a CLI that can process network interrupts only by the local NUMA node.
As I remember, the set system option performance xxx option overrides some sysctl options if it is not fixed.
Otherwise, we have to use customer scripts to balance interrupts on the required cores.

syncer added a subscriber: Global Notifications.Nov 1 2024, 9:19 PM