Page MenuHomeVyOS Platform
Create Task
Maniphest T4373

PPPoE-server add multiplier option for shaper
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Allow to set rate-multiplier for PPPoE clients section [shaper]
Proposed CLI

set service pppoe-server authentication radius rate-limit multiplier 0.001

pppoe.conf

[shaper]
rate-multiplier=0.001

Requested form forum

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Related Objects

Event Timeline

Viacheslav created this task.Apr 19 2022, 5:28 AM
Viacheslav changed the task status from Open to In progress.Apr 19 2022, 5:31 AM
Viacheslav claimed this task.
pasik subscribed.Apr 19 2022, 7:46 AM
Viacheslav added a comment.Apr 19 2022, 11:09 AM

PR https://github.com/vyos/vyos-1x/pull/1290

Restricted Repository Identity mentioned this in rVYOSONEX9347dc53c5bd: Merge pull request #1290 from sever-sever/T4373.May 16 2022, 3:55 PM
Viacheslav mentioned this in rVYOSONEXb9e1a141ee2a: pppoe-server: T4373: Add option multiplier for correct shaping.May 16 2022, 3:55 PM
Viacheslav changed the task status from In progress to Needs testing.May 16 2022, 5:26 PM

Need testing:

set service pppoe-server authentication mode 'radius'
set service pppoe-server authentication radius rate-limit attribute 'Mikrotik-Rate-Limit'
set service pppoe-server authentication radius rate-limit enable
set service pppoe-server authentication radius rate-limit multiplier '0.001'
set service pppoe-server authentication radius rate-limit vendor 'Mikrotik'
set service pppoe-server authentication radius server 192.0.2.1 key 'foo'
set service pppoe-server client-ip-pool start '192.0.2.5'
set service pppoe-server client-ip-pool stop '192.0.2.254'
set service pppoe-server gateway-address '192.0.2.1'
set service pppoe-server interface eth3

Or any live example

Viacheslav added a project: VyOS 1.3 Equuleus (1.3.2).Jul 5 2022, 12:30 PM
Viacheslav added a comment.Jul 5 2022, 1:23 PM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/1392

Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Jul 5 2022, 1:24 PM
Restricted Repository Identity mentioned this in rVYOSONEXddfb571f83ce: Merge pull request #1392 from sever-sever/T4507-eq.Jul 9 2022, 9:32 AM
Viacheslav mentioned this in rVYOSONEX14a7a85b49cc: pppoe-server: T4373: Add option multiplier for correct shaping.Jul 9 2022, 9:33 AM
Viacheslav closed this task as Resolved.Jul 9 2022, 9:33 AM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.2) board.
dmbaturin mentioned this in 1.3.2.Sep 5 2022, 3:14 PM
dmbaturin mentioned this in 1.3.2.Sep 15 2022, 10:42 AM