Page MenuHomeVyOS Platform
Create Task
Maniphest T4369

OpenVPN: daemon not restarted on changes to "openvpn-option" CLI node
Closed, ResolvedPublicBUG
Actions

Description

Also reported by @dmbaturin on one of out meetings.

Changing, adding, removing to openvpn-config CLI node is not respected. A change to this node requires OpenVPN to be restarted as these options are passed via systemd.

Thus when adding a new option it is not activated until OpenVPN daemon is restarted (by reboot or manually)

Details

Version
1.4-rolling-202204161537
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

c-po created this task.Apr 18 2022, 9:53 AM
c-po claimed this task.
pasik subscribed.Apr 18 2022, 10:16 AM
c-po mentioned this in rVYOSONEXc685c0f762ea: vyos.configdict(): T4369: leaf_node_changed() must return True when node is….Apr 18 2022, 10:28 AM
c-po added a comment.EditedApr 18 2022, 10:31 AM

PR for 1.3: https://github.com/vyos/vyos-1x/pull/1308

c-po mentioned this in rVYOSONEX1a1094c28e32: vyos.configdict(): T4369: bugfix - execution order in leaf_node_changed().Apr 18 2022, 5:26 PM
c-po mentioned this in rVYOSONEX714346e2ee0c: vyos.configdict: T4369: add is_node_changed() helper.Apr 20 2022, 12:23 PM
c-po mentioned this in rVYOSONEXe36efa6b5df7: openvpn: T4369: enforce daemon-restart on openvpn-option CLI change.
c-po mentioned this in rVYOSONEX1fe3123a1b89: Revert "vyos.configdict(): T4369: bugfix - execution order in leaf_node_changed….Apr 20 2022, 3:17 PM
c-po mentioned this in rVYOSONEX200133efbd5b: Revert "vyos.configdict(): T4369: leaf_node_changed() must return True when….
c-po added a project: VyOS 1.3 Equuleus (1.3.2).Apr 29 2022, 6:07 PM
Restricted Repository Identity mentioned this in rVYOSONEXc9e362224a72: Merge pull request #1308 from c-po/t4369-openvpn-equuleus.Apr 29 2022, 7:36 PM
c-po mentioned this in rVYOSONEXdde78e8024de: openvpn: T4369: enforce daemon-restart on openvpn-option CLI change.Apr 29 2022, 7:36 PM
c-po mentioned this in rVYOSONEX598e88f6d0e6: vyos.configdict: T4369: add is_node_changed() helper.
c-po closed this task as Resolved.May 1 2022, 6:20 AM
c-po triaged this task as Normal priority.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.2) board.
c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
c-po edited a custom field.
dmbaturin mentioned this in 1.3.2.Sep 5 2022, 3:14 PM
dmbaturin mentioned this in 1.3.2.Sep 15 2022, 10:42 AM