Page MenuHomeVyOS Platform
Create Task
Maniphest T4347

Return complete and consistent error codes from HTTP API
Closed, ResolvedPublic
Actions

Description

To support the HTTP API smoketest, return complete and consistent HTTP error codes. Namely, 50.* errors should no longer redirect to provide an error message; the middleware that translates form-data requests to JSON should return 401, instead of 422, on missing key.

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

jestabro changed the task status from Open to In progress.Apr 7 2022, 9:05 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro changed the task status from In progress to Needs testing.Apr 7 2022, 9:13 PM
jestabro added a comment.Apr 7 2022, 9:21 PM

Changes and fixes to smoketest at link; in testing before PR:
https://github.com/vyos/vyos-1x/compare/current...jestabro:api-smoketest

jestabro added a comment.Apr 7 2022, 11:57 PM

PR:
https://github.com/vyos/vyos-1x/pull/1277

jestabro changed the task status from Needs testing to In progress.Apr 7 2022, 11:58 PM
jestabro closed this task as Resolved.Apr 8 2022, 8:16 AM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
pasik added a subscriber: pasik.Apr 8 2022, 8:20 AM