Return complete and consistent error codes from HTTP API
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jestabro
	Apr 7 2022, 9:05 PM

Description

To support the HTTP API smoketest, return complete and consistent HTTP error codes. Namely, 50.* errors should no longer redirect to provide an error message; the middleware that translates form-data requests to JSON should return 401, instead of 422, on missing key.

Details

Version: vyos-1.4
Is it a breaking change?: Perfectly compatible

Related Objects

Mentioned In: rVYOSONEX4c89134c632d: http api: T4347: return complete and consistent error codes
rVYOSONEX5399a8f75b5a: Merge pull request #1277 from jestabro/api-smoketest

Event Timeline

jestabro created this task.Apr 7 2022, 9:05 PM

jestabro changed the task status from Open to In progress.

jestabro triaged this task as Normal priority.

jestabro created this object in space S1 VyOS Public.

jestabro changed the task status from In progress to Needs testing.Apr 7 2022, 9:13 PM

Changes and fixes to smoketest at link; in testing before PR:
https://github.com/vyos/vyos-1x/compare/current...jestabro:api-smoketest

PR:
https://github.com/vyos/vyos-1x/pull/1277

jestabro changed the task status from Needs testing to In progress.Apr 7 2022, 11:58 PM

Restricted Repository Identity mentioned this in rVYOSONEX5399a8f75b5a: Merge pull request #1277 from jestabro/api-smoketest.Apr 8 2022, 5:11 AM

jestabro mentioned this in rVYOSONEX4c89134c632d: http api: T4347: return complete and consistent error codes.Apr 8 2022, 5:11 AM

jestabro closed this task as Resolved.Apr 8 2022, 8:16 AM

jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.

pasik subscribed.Apr 8 2022, 8:20 AM

Return complete and consistent error codes from HTTP APIClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Return complete and consistent error codes from HTTP API
Closed, ResolvedPublic
Actions