Heya everyone. Just wanted to have discussions on changing the leaf node of the BGP autonomous system number to more accurately reflect what it does.
Currently it looks like this:
vyos@vyos# set protocols bgp local-as Autonomous System Number (ASN)
Per looking at it, and conversing with C-Po I believe it would be better if we change to:
vyos@vyos# set protocols bgp asn Autonomous System Number (ASN)
or
vyos@vyos# set protocols bgp as-number Autonomous System Number (ASN)
Really we can use anything, but I would like for us to go away from using "local-as" as it's a specific feature under neighbor creation that uses the same nomenclature.
Does this seem like a reasonable change?
Also, if maintainers deem it appropriate then I am completely ok with taking the task on myself and figuring it out and getting a PR out.
One consideration we might have to keep in mind is that from 1.3 to 1.4 there's already a change to the BGP AS number. Now within 1.4 there will be another change. I don't want to just make changes to existing nodes that are in place, but I feel this one specifically is needed just to help alleviate confusion between global AS number for the router, and local AS setting for a neighbor.
Thank you much :)