Page MenuHomeVyOS Platform
Create Task
Maniphest T4029

Broken SFTP uploads
Closed, ResolvedPublic
Actions

Description

T3356: broke uploads to SFTP with the following error.

TypeError: __init__() got an unexpected keyword argument 'source'

The source kwarg is None so it needs to be popped somewhere.

Details

Version
VyOS 1.4 Sagitta
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 ResolvedFEATURE REQUESTerkinT3356 Script for remote file transfers
 ResolvederkinT4029 Broken SFTP uploads

Event Timeline

scj643 created this task.Nov 30 2021, 9:59 PM
scj643 triaged this task as High priority.
scj643 created this object in space S1 VyOS Public.
pasik subscribed.Nov 30 2021, 10:05 PM
erkin claimed this task.Dec 2 2021, 2:17 PM
erkin added a parent task: T3356: Script for remote file transfers.Dec 2 2021, 2:32 PM
scj643 added a comment.Dec 2 2021, 6:15 PM

https://github.com/vyos/vyatta-config-mgmt/blob/current/scripts/vyatta-commit-push.pl#L71-L82 seems to be the root cause for this.

Viacheslav changed the task status from Open to Needs testing.Dec 11 2021, 9:38 AM
Viacheslav subscribed.EditedDec 11 2021, 9:47 AM

Still with issues, VyOS 1.4-rolling-202112090318:

vyos@r11-roll# set system config-management commit-archive location sftp://foo:foo@192.168.122.14/
[edit]
vyos@r11-roll# commit
Archiving config...
  sftp://192.168.122.14/ Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 312, in upload
    urlc(urlstring, *args, **kwargs).upload(local_path)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 202, in upload
    with self._establish() as ssh, ssh.open_sftp() as sftp:
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 189, in _establish
    sock = socket.create_connection((self.hostname, self.port), socket.getdefaulttimeout(), self.source)
  File "/usr/lib/python3.9/socket.py", line 830, in create_connection
    sock.bind(source_address)
TypeError: str, bytes or bytearray expected, not NoneType
[edit]
vyos@r11-roll# 
[edit]

But save is working:

vyos@r11-roll# save sftp://foo:foo@192.168.122.14/
Saving configuration to 'sftp://foo:foo@192.168.122.14/'...
Done
[edit]
vyos@r11-roll#
Viacheslav lowered the priority of this task from High to Normal.Dec 11 2021, 10:25 AM
Viacheslav added a comment.Dec 11 2021, 10:48 AM

PR https://github.com/vyos/vyatta-config-mgmt/pull/7

erkin closed this task as Resolved.Dec 16 2021, 2:06 PM
c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Dec 26 2021, 10:09 AM