Maniphest T3964

SSTP: local-user static-ip CLI node accepts invalid IPv4 addresses
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Nov 3 2021, 6:53 PM

Tags

Referenced Files

None

Subscribers

Description

cpo@LR2.wue3# set vpn sstp authentication local-users username foo static-ip 1.2.3.9999
[edit]

XML code lacs a constraint section

<leafNode name="static-ip">
  <properties>
    <help>Static client IP address</help>
  </properties>
  <defaultValue>*</defaultValue>
</leafNode>

Details

Version: 1.3.0-epa2
Is it a breaking change?: Stricter validation
Issue type: Bug (incorrect behavior)

Related Objects

Mentioned In: rVYOSONEX8dcb08991679: sstp: accel-ppp: T3964: add missing input validator for static-ip assignment
rVYOSONEX8bfece476c09: Merge pull request #1063 from vyos/t3964-add-missing-validator
rVYOSONEXb8f702bc7b6e: sstp: accel-ppp: T3964: add missing input validator for static-ip assignment

Event Timeline

c-po created this task.Nov 3 2021, 6:53 PM

c-po claimed this task.

c-po added a project: VyOS 1.4 Sagitta.

c-po updated the task description. (Show Details)

Restricted Repository Identity mentioned this in rVYOSONEXb8f702bc7b6e: sstp: accel-ppp: T3964: add missing input validator for static-ip assignment.Nov 3 2021, 7:03 PM

pasik subscribed.Nov 3 2021, 7:09 PM

Restricted Repository Identity mentioned this in rVYOSONEX8bfece476c09: Merge pull request #1063 from vyos/t3964-add-missing-validator.Nov 4 2021, 10:55 AM

c-po mentioned this in rVYOSONEX8dcb08991679: sstp: accel-ppp: T3964: add missing input validator for static-ip assignment.Nov 4 2021, 10:55 AM

c-po closed this task as Resolved.Nov 4 2021, 10:57 AM

c-po triaged this task as Low priority.

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Nov 5 2021, 8:24 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 11:42 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:17 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.